Add docker installation to the default ubuntu config #87
Conversation
Signed-off-by: Dax McDonald <[email protected]>
| @@ -38,7 +38,14 @@ | |||
| { | |||
| "type": "shell", | |||
| "inline": [ | |||
| "touch /tmp/test" | |||
| "mv /etc/resolv.conf /etc/resolv.conf.bk", | |||
There was a problem hiding this comment.
If this is going to be added I would do it as a seperate provisioner. I'd also suggest using Ansible rather than a shell script. However overall I think this pollutes the board image generation and should be done via optionally calling into another builder.
There was a problem hiding this comment.
Depends... ansible is good at idempotent playbooks, that are re-run to update a machine... the update case does not exist here... that is why also ansible/puppet/chef are not used inside a Dockerfile... the packer configs here also run always end2end similar to a Dockerfile ... no need to bring in a ansible..
Another way would be extracting the added code here to e.g. ./scripts/setup-docker-ubuntu.sh ... and use it from there inside a provisioner... similar to the resize scripts already in the scripts folder.. this would make it a bit more reusable...
|
Extracted the logic into a separate provision script and mentioning the scripts in the README.md. It's always good to have more arm specific example scripts as inspiration when setting up own boards. |
Continuation of #86
Happy to not add this if this exceeds what the base installation should do
Signed-off-by: Dax McDonald [email protected]