[OPTDEV-2284] Fixes for step_partition_image.go
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code has bugs in MBR/DOS partitioniong, so narrow use cases fail miserably. Additionally output handling is improved.
dbast
approved these changes
Jul 15, 2023
|
thanks! |
|
@dbast are you going to maintain this repo now? |
|
I can, but have no permissions to enable more maintainers or to the rename required for the plugin. |
|
I'm not sure rename is still required in recent versions. Some people who forked shown demo without renaming. I haven't been there yet, some other stuff takes priority at work with our September release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code has bugs in MBR/DOS partitioniong, so narrow use cases fail miserably.
Additionally output handling is improved.