Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE thrown when configuration has null values for durations. #183

Open
mk23 opened this issue May 31, 2018 · 1 comment
Open

NPE thrown when configuration has null values for durations. #183

mk23 opened this issue May 31, 2018 · 1 comment
Assignees

Comments

@mk23
Copy link
Owner

mk23 commented May 31, 2018

For example, if clean_interval is null in config, this is thrown:

13:17:40.411 [main]            ERROR io.dropwizard.cli.ServerCommand - Unable to start server, shutting down
org.eclipse.jetty.util.MultiException: Multiple exceptions
	at org.eclipse.jetty.server.Server.doStart(Server.java:382)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
	at io.dropwizard.cli.ServerCommand.run(ServerCommand.java:53)
	at io.dropwizard.cli.EnvironmentCommand.run(EnvironmentCommand.java:44)
	at io.dropwizard.cli.ConfiguredCommand.run(ConfiguredCommand.java:85)
	at io.dropwizard.cli.Cli.run(Cli.java:75)
	at io.dropwizard.Application.run(Application.java:93)
	at com.github.mk23.jmxproxy.JMXProxyApplication.main(JMXProxyApplication.java:42)
	Suppressed: java.util.concurrent.RejectedExecutionException: org.eclipse.jetty.io.ManagedSelector$$Lambda$46/665137804@1e5f4170
		at org.eclipse.jetty.util.thread.QueuedThreadPool.execute(QueuedThreadPool.java:402)
		at org.eclipse.jetty.io.SelectorManager.execute(SelectorManager.java:171)
		at org.eclipse.jetty.io.ManagedSelector.doStart(ManagedSelector.java:101)
		at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
		at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
		at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:115)
		at org.eclipse.jetty.io.SelectorManager.doStart(SelectorManager.java:271)
		at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
		at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
		at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:107)
		at org.eclipse.jetty.server.AbstractConnector.doStart(AbstractConnector.java:278)
		at org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:81)
		at org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:238)
		at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
		at org.eclipse.jetty.server.Server.doStart(Server.java:397)
		... 7 common frames omitted
Caused by: java.lang.NullPointerException: null
	at com.github.mk23.jmxproxy.jmx.ConnectionManager.start(ConnectionManager.java:232)
	at io.dropwizard.lifecycle.JettyManaged.doStart(JettyManaged.java:27)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:133)
	at org.eclipse.jetty.server.Server.start(Server.java:418)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:115)
	at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:113)
	at org.eclipse.jetty.server.Server.doStart(Server.java:385)
	... 7 common frames omitted
@mk23 mk23 added this to the jmxproxy.3.4.1 milestone May 31, 2018
@mk23 mk23 self-assigned this May 31, 2018
@mk23
Copy link
Owner Author

mk23 commented May 31, 2018

Add null checks and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant