You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are looking to use write_refs() in our ESHackathon/CiteSource package. For that, I was passing a tibble to write_refs and wondered why it fails - since it also has the data.frame class. This is because your check for classes depends on their precise position when there is more than one ... instead of
- swap from `data.frame` to `tibble` format throughout package
- decommission `class() ==` syntax in favor of `inherits()` #22
- make `merge_columns()` a shell for `dplyr::bind_rows()`
We are looking to use
write_refs()
in our ESHackathon/CiteSource package. For that, I was passing a tibble to write_refs and wondered why it fails - since it also has thedata.frame
class. This is because your check for classes depends on their precise position when there is more than one ... instead ofsynthesisr/R/write_refs.R
Line 127 in c406bc9
it might be better to use
if (inherits(x, "data.frame") || inherits(x, "bibliography"))
That would allow tibbles and generally be more robust ...
The text was updated successfully, but these errors were encountered: