Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ordering of columns #3

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

mjsqu
Copy link
Owner

@mjsqu mjsqu commented Sep 21, 2022

Problem

As part of the checking for duplicate columns, the columns are sorted by name. This results in the output table having columns ordered alphabetically - not how they were provided by the source.

Proposed changes

Leave the sorted_items variable in place for checking only and use the items variable instead as the basis for table creation.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@mjsqu
Copy link
Owner Author

mjsqu commented Sep 21, 2022

target-snowflake sorts the column list before checking it for duplicates but then uses the sorted version instead of unsorted

@mjsqu mjsqu merged commit 0c9349f into master Sep 21, 2022
@mjsqu mjsqu deleted the feature/remove_ordering_of_columns branch September 21, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant