chore: final classes & unused imports

- Add 'final' keyword to classes that are not meant to be extended
- Remove unused imports

.php-cs-fixer.dist.php

@@ -32,6 +32,7 @@
         'phpdoc_types' => true,
         'phpdoc_scalar' => true,
         'phpdoc_align' => true,
+        'no_unused_imports' => true,
         'array_syntax' => ['syntax' => 'short'],
         'header_comment' => ['header' => $header],
     ])

bin/resque

@@ -10,9 +10,6 @@
  * file that was distributed with this source code.
  */
 
-/**
- * The main point of entry for the php-resque commands
- */
 if (!ini_get('date.timezone') or ! date_default_timezone_get()) {
     date_default_timezone_set('UTC');
 }

src/Config.php

@@ -13,7 +13,6 @@
 
 use InvalidArgumentException;
 use Resque\Helpers\Util;
-use Resque\Redis;
 use RuntimeException;
 use Symfony\Component\Yaml\Exception\ParseException;
 use Symfony\Component\Yaml\Yaml;
@@ -24,7 +23,7 @@
  * @package Resque
  * @author Paul Litovka
  */
-class Config
+final class Config
 {
     /**
      * Default config file name
@@ -51,10 +50,8 @@ class Config
      * Reads and loads data from a config file
      *
      * @param string $file The config file path
-     *
-     * @return bool
      */
-    public static function loadConfig(string $file = self::DEFAULT_CONFIG_FILE): bool
+    public static function loadConfig(string $file = self::DEFAULT_CONFIG_FILE): void
     {
         static::$config = static::parseConfig($file);
 
@@ -68,8 +65,6 @@ public static function loadConfig(string $file = self::DEFAULT_CONFIG_FILE): boo
             'phpiredis'  => static::read('redis.phpiredis', Redis::DEFAULT_PHPIREDIS),
             'predis'     => static::read('predis'),
         ]);
-
-        return true;
     }
 
     /**

src/Console/Command/Cleanup.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command;
 
-use Resque\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 

src/Console/Command/Clear.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command;
 
-use Resque\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;

src/Console/Command/Hosts.php

@@ -11,8 +11,6 @@
 
 namespace Resque\Console\Command;
 
-use Resque\Resque;
-use Resque\Console\Command\Command;
 use Resque\Host;
 use Resque\Redis;
 use Symfony\Component\Console\Input\InputInterface;

src/Console/Command/Queues.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command;
 
-use Resque\Console\Command\Command;
 use Resque\Queue;
 use Resque\Redis;
 use Symfony\Component\Console\Input\InputInterface;

src/Console/Command/Socket/Connect.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command\Socket;
 
-use Resque\Resque;
 use Resque\Console\Command\Command;
 use Resque\Socket\Server;
 use Symfony\Component\Console\Input\InputInterface;

src/Console/Command/Socket/Receive.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command\Socket;
 
-use Resque\Resque;
 use Resque\Job;
 use Resque\Host;
 use Resque\Worker;

src/Console/Command/Socket/Send.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command\Socket;
 
-use Resque\Resque;
 use Resque\Console\Command\Command;
 use Resque\Socket\Server;
 use Symfony\Component\Console\Input\InputArgument;

src/Console/Command/SpeedTest.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command;
 
-use Resque\Console\Command\Command;
 use Resque\Redis;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;

src/Console/Command/Worker/Cancel.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command\Worker;
 
-use Resque\Resque;
 use Resque\Console\Command\Command;
 use Resque\Worker;
 use Symfony\Component\Console\Input\InputArgument;

src/Console/Command/Worker/Pause.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command\Worker;
 
-use Resque\Resque;
 use Resque\Console\Command\Command;
 use Resque\Worker;
 use Symfony\Component\Console\Input\InputArgument;

src/Console/Command/Worker/Restart.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command\Worker;
 
-use Resque\Resque;
 use Resque\Console\Command\Command;
 use Resque\Worker;
 use Symfony\Component\Console\Input\InputArgument;

src/Console/Command/Worker/Resume.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command\Worker;
 
-use Resque\Resque;
 use Resque\Console\Command\Command;
 use Resque\Worker;
 use Symfony\Component\Console\Input\InputArgument;

src/Console/Command/Worker/Stop.php

@@ -11,7 +11,6 @@
 
 namespace Resque\Console\Command\Worker;
 
-use Resque\Resque;
 use Resque\Console\Command\Command;
 use Resque\Worker;
 use Symfony\Component\Console\Input\InputArgument;

src/Console/Command/Workers.php

@@ -11,8 +11,6 @@
 
 namespace Resque\Console\Command;
 
-use Resque\Resque;
-use Resque\Console\Command\Command;
 use Resque\Helpers\Util;
 use Resque\Worker;
 use Symfony\Component\Console\Input\InputInterface;

src/Event.php

@@ -17,7 +17,7 @@
  * @package Resque
  * @author Michael Haynes
  */
-class Event
+final class Event
 {
     // Worker event constants
     public const WORKER_INSTANCE       = 100;

src/Helpers/CatchOutput.php

@@ -19,7 +19,7 @@
  * @package Resque
  * @author Michael Haynes
  */
-class CatchOutput extends \Symfony\Component\Console\Output\Output
+final class CatchOutput extends \Symfony\Component\Console\Output\Output
 {
     /**
      * @var string Stored output string

src/Helpers/ClosureJob.php

@@ -17,7 +17,7 @@
  * @package Resque
  * @author Michael Haynes
  */
-class ClosureJob
+final class ClosureJob
 {
     /**
      * Fire the Closure based queue job.

src/Helpers/SerializableClosure.php

@@ -17,7 +17,7 @@
  * @package Resque
  * @author Michael Haynes
  */
-class SerializableClosure
+final class SerializableClosure
 {
     /**
      * The Closure instance.

src/Helpers/Stats.php

@@ -19,7 +19,7 @@
  * @package Resque
  * @author Michael Haynes
  */
-class Stats
+final class Stats
 {
     public const DEFAULT_KEY = 'stats';
 

src/Helpers/Table.php

@@ -20,7 +20,7 @@
  * @package Resque
  * @author Michael Haynes
  */
-class Table
+final class Table
 {
     /**
      * @var TableHelper

src/Helpers/Util.php

@@ -17,7 +17,7 @@
  * @package Resque
  * @author Michael Haynes
  */
-class Util
+final class Util
 {
     /**
      * Returns human readable sizes. Based on original functions written by

src/Logger.php

@@ -19,7 +19,7 @@
  * @package Resque
  * @author Michael Haynes
  */
-class Logger
+final class Logger
 {
     /**
      * Detailed debug information

src/Queue.php

@@ -17,7 +17,7 @@
  * @package Resque
  * @author Michael Haynes
  */
-class Queue
+final class Queue
 {
     /**
      * @var Redis The Redis instance

src/Redis.php

@@ -19,7 +19,7 @@
  * @package Resque
  * @author Michael Haynes
  */
-class Redis
+final class Redis
 {
     /**
      * Default Redis connection scheme

src/Resque.php

@@ -11,9 +11,6 @@
 
 namespace Resque;
 
-use Resque\Redis;
-use Resque\Queue;
-
 /**
  * Main Resque class
  *