Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Broadlink LB1 bulb (0x644B) #717

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Add support for Broadlink LB1 bulb (0x644B) #717

merged 2 commits into from
Nov 20, 2022

Conversation

comptonjack
Copy link

Context

Home Assistant returning the error "Unsupported device: 0x644b".

Proposed change

Adding a new type for the LB1 bulb (0x644B).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

  • This PR fixes issue: N/A
  • This PR is related to: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black.
  • The code follows the Zen of Python.
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated.

@comptonjack comptonjack changed the title Adding support for LB1 bulb 0x644B Add support for Broadlink LB1 bulb (0x644B) Sep 22, 2022
@felipediel felipediel merged commit 74fc15b into mjg59:new_product_ids Nov 20, 2022
@felipediel
Copy link
Collaborator

Thank you @compdog!

@felipediel felipediel mentioned this pull request Nov 20, 2022
Merged
13 tasks
felipediel added a commit that referenced this pull request Nov 20, 2022
@compdog @felipediel
Add support for Broadlink LB1 bulb (0x644B) (#717)
6c6066a 
* Adding support for LB1 bulb 0x644B

* Sort product ids

Co-authored-by: Felipe Martins Diel <[email protected]>
felipediel added a commit that referenced this pull request Nov 20, 2022
@felipediel
Merge new product ids into master (#726)
9d5339a 
* Add support for RM4C mini (0x520D) (#694)

* Add support for SP4L-US (0x648C) (#707)

* Add support for RM4C mate (0x5211) (#709)

* Add support for RM4 mini (0x521C) (#710)

* Add support for LB1 (0x644B) (#717)
@felipediel felipediel mentioned this pull request Nov 20, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@comptonjack @felipediel