Skip to content

Commit

Permalink
WebGL: Fix WebGLImageChromium P3 canvases
Browse files Browse the repository at this point in the history
The regressed in crrev.com/1028719. It managed to get to stable,
because it only affects overlay paths, and all testing for WebGL (and
2D) canvas is via readback or non-overlay compositing.

This will require a pixel test (for WebGL and for 2D canvas).

Bug: 1370806
Change-Id: If5e1f4f54322929886918a94ad9f91ea8cb0b06a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3932600
Reviewed-by: Kenneth Russell <[email protected]>
Commit-Queue: ccameron chromium <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1054652}
NOKEYCHECK=True
GitOrigin-RevId: 9c96ebc04c075dd6dd86242f43d645192b6b5a7e
  • Loading branch information
ccameron-chromium authored and copybara-github committed Oct 4, 2022
1 parent b0108a7 commit 2a1f86e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions blink/renderer/platform/graphics/gpu/drawing_buffer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1863,6 +1863,7 @@ scoped_refptr<DrawingBuffer::ColorBuffer> DrawingBuffer::CreateColorBuffer(
size, buffer_format, buffer_usage, gpu::kNullSurfaceHandle,
nullptr);
if (gpu_memory_buffer) {
gpu_memory_buffer->SetColorSpace(color_space_);
back_buffer_mailbox = sii->CreateSharedImage(
gpu_memory_buffer.get(), gpu_memory_buffer_manager, color_space_,
origin, kPremul_SkAlphaType, usage | additional_usage_flags);
Expand Down

0 comments on commit 2a1f86e

Please sign in to comment.