Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add tasks or open lists with custom region settings #108

Closed
antonlarin opened this issue Apr 24, 2016 · 3 comments
Closed

Can't add tasks or open lists with custom region settings #108

antonlarin opened this issue Apr 24, 2016 · 3 comments
Assignees
Labels

Comments

@antonlarin
Copy link

I customized time representation through System Preferences on my system and that apparently doesn't work well with TodoTxtMac. The app doesn't add tasks (pressing Enter simply removes focus from TextArea) and it doesn't open existing lists. To be more specific, I'm using the preset for Russian region but with 12-hour time format (default is 24-hour).

I used the debugger and found out that NSDateFormatter fails to parse the fake due date and returns nil here which then it's being used here, causing the exception. Adding [dateFormatter setLocale:[NSLocale systemLocale]]; after that line seems to fix the issues that I'm experiencing, but I don't know whether that could be considered a solution.

@mjdescy
Copy link
Owner

mjdescy commented Apr 25, 2016

@antonlarin Thank you for this bug report. I was wondering when locale-related bugs would surface.

I will look into your proposed solution and try to see if it has any unintended consequences. Thanks for being so thorough.

@mjdescy mjdescy added the bug label Apr 25, 2016
@mjdescy mjdescy self-assigned this Apr 25, 2016
mjdescy added a commit that referenced this issue Apr 25, 2016
…ettings.

- Changed NSDateFormatter locale in TTMDateUtility class to work around bugs related to setting the "high" date in some locales (namely Russia with 12 hour clock).
- Integration tests were performed with several locales. Unit tests all passed.
@mjdescy
Copy link
Owner

mjdescy commented Apr 25, 2016

@antonlarin Try version 2.2.2. It should fix your bug.

@mjdescy mjdescy closed this as completed Apr 25, 2016
@antonlarin
Copy link
Author

That was really quick, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants