Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EINVAL undeclared on MINGW #30

Closed
tresf opened this issue Oct 11, 2017 · 5 comments
Closed

EINVAL undeclared on MINGW #30

tresf opened this issue Oct 11, 2017 · 5 comments
Assignees
Labels

Comments

@tresf
Copy link

tresf commented Oct 11, 2017

Reading rpmalloc.c it appears as though EINVAL is never defined properly for MINGW environments. I think this is provided by <errno.h> but this seems to be disabled for Win32 builds.

The build log is available here.

@tresf tresf changed the title EINVAL undeclared EINVAL undeclared on MINGW Oct 11, 2017
@mjansson mjansson self-assigned this Oct 11, 2017
@mjansson mjansson added the bug label Oct 11, 2017
@mjansson
Copy link
Owner

Try the latest develop branch, moved the errno.h include to always include (it was not needed for msvc compilation, which is why it was not included in windows builds before).

@mjansson
Copy link
Owner

mjansson commented Oct 11, 2017

Btw, in your LMMS PR LMMS/lmms#3873 you probably mistyped the thread finalization in MemoryManager::ThreadGuard::~ThreadGuard(), see my comment in your PR

@mjansson
Copy link
Owner

If it fixes your build I'll do tests and then a merge to master and a 1.2.1 release to make it easier for you to use as a submodule.

lukas-w added a commit to LMMS/lmms that referenced this issue Oct 11, 2017
@mjansson
Copy link
Owner

I see the build completed now, but I'll leave this issue open for now until it is merged to master.

@mjansson
Copy link
Owner

Merged to master, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants