Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altered Naming Convention for Duplicates #640

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Ammelll
Copy link

@Ammelll Ammelll commented Mar 13, 2024

In my experience the current naming convention of "Copy of {AutoName}" is very inconvenient, primarily when sorting the Path/Auto names alphabetically as duplicating an auto will send it to a random place in the stack instead of right next to the Path/Auto being duplicated. I believe the changes I've proposed would address this.

@github-actions github-actions bot added the GUI Changes to the PathPlanner GUI label Mar 13, 2024
@rjbell4
Copy link

rjbell4 commented Mar 29, 2024

I concur that something that appends a suffix would be preferred over something the prepends a prefix, as it would result in less scrolling when creating new paths or autos by duplicating something that exists and then modifying it.

@mjansen4857
Copy link
Owner

Just checking in on the status of this as it still has failing tests and needs to be formatted.

You can format by running dart format . in the root of the project directory.

@Ammelll
Copy link
Author

Ammelll commented Dec 13, 2024

The only test this was failing was test's for duplicate auto and duplicate path names (expected). How do you suggest I make these tests pass given I'm changing their function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Changes to the PathPlanner GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants