Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Choreo Interoperability #505

Merged
merged 15 commits into from
Dec 11, 2023
Merged

Initial Choreo Interoperability #505

merged 15 commits into from
Dec 11, 2023

Conversation

mjansen4857
Copy link
Owner

  • Run Chore trajectories in PPLib
  • Create autos using Choreo trajectories in GUI

@github-actions github-actions bot added dependencies Pull requests that update a dependency file GUI Changes to the PathPlanner GUI PathPlannerLib Changes to PathPlannerLib labels Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 87 lines in your changes are missing coverage. Please review.

Comparison is base (fa137cf) 85.65% compared to head (d7f9f6c) 85.49%.

Files Patch % Lines
lib/pages/home_page.dart 0.00% 50 Missing ⚠️
lib/pages/project/project_page.dart 84.61% 20 Missing ⚠️
lib/widgets/editor/split_choreo_path_editor.dart 90.90% 8 Missing ⚠️
lib/pages/choreo_path_editor_page.dart 89.65% 3 Missing ⚠️
lib/path/choreo_path.dart 88.00% 3 Missing ⚠️
lib/pages/auto_editor_page.dart 95.23% 1 Missing ⚠️
lib/widgets/editor/path_painter.dart 97.87% 1 Missing ⚠️
lib/widgets/editor/split_auto_editor.dart 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
- Coverage   85.65%   85.49%   -0.17%     
==========================================
  Files          73       77       +4     
  Lines        6269     6675     +406     
==========================================
+ Hits         5370     5707     +337     
- Misses        899      968      +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjansen4857 mjansen4857 marked this pull request as ready for review December 11, 2023 20:43
@mjansen4857 mjansen4857 merged commit b05123c into main Dec 11, 2023
19 checks passed
@mjansen4857 mjansen4857 deleted the choreo-traj branch December 11, 2023 20:50
@tbeadle
Copy link

tbeadle commented Dec 11, 2023

I had never heard of Choreo before, so thanks for this. It looks pretty cool. I know you've been cranking out stuff like crazy, but since I'm very interested in this feature, are you planning on adding something to the wiki about it? Thanks again for all the amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file GUI Changes to the PathPlanner GUI PathPlannerLib Changes to PathPlannerLib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants