Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use WinRM::Connection for winrm >= 2.0 #608

Merged
merged 2 commits into from
May 17, 2019
Merged

use WinRM::Connection for winrm >= 2.0 #608

merged 2 commits into from
May 17, 2019

Conversation

sawanoboly
Copy link
Collaborator

spec_helper raises uninitialized constant WinRM::WinRMWebService since winrm 2.0. So, I branched the initialization of winrm instance.

  • use WinRM::Connection for winrm 2.x
  • [compatibility] winrm >= 2.0 doesn't support ruby 1.9

Since the backend of specinfra also needs updating, I will make a PR to specinfra as well.

@mizzy
Copy link
Owner

mizzy commented May 17, 2019

Thanks!

@mizzy mizzy merged commit 516be88 into master May 17, 2019
@mizzy mizzy deleted the newer_winrm branch May 17, 2019 12:27
@mizzy
Copy link
Owner

mizzy commented May 17, 2019

Released as v2.41.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sawanoboly @mizzy