add test cases for 3rd-party plugin

mizdra · Sep 25, 2024 · 160a504 · 160a504
1 parent c9d9114
commit 160a504
Show file tree

Hide file tree

Showing 2 changed files with 81 additions and 17 deletions.
diff --git a/src/__snapshots__/core.test.ts.snap b/src/__snapshots__/core.test.ts.snap
@@ -69,6 +69,20 @@ exports[`Core > disablePerLine 1`] = `
 let a = 1;"
 `;
 
+exports[`Core > fixes problems with legacy config and 3rd-party plugins 1`] = `
+"// eslint-disable-next-line test/ban-nullish-coalescing-operator
+// eslint-disable-next-line test/ban-nullish-coalescing-operator
+// eslint-disable-next-line test/ban-nullish-coalescing-operator
+// eslint-disable-next-line test/ban-nullish-coalescing-operator
+// eslint-disable-next-line test/ban-nullish-coalescing-operator
+// eslint-disable-next-line test/ban-nullish-coalescing-operator
+// eslint-disable-next-line test/ban-nullish-coalescing-operator
+// eslint-disable-next-line test/ban-nullish-coalescing-operator
+// eslint-disable-next-line test/ban-nullish-coalescing-operator
+// eslint-disable-next-line test/ban-nullish-coalescing-operator
+2 ?? 2;"
+`;
+
 exports[`Core > flat config 1`] = `
 [
   {
@@ -194,6 +208,17 @@ exports[`Core > lint > returns lint results 1`] = `
     ],
     "warningCount": 0,
   },
+  {
+    "errorCount": 1,
+    "filePath": "<fixture>/src/ban-nullish-coalescing-operator.js",
+    "messages": [
+      {
+        "ruleId": "test/ban-nullish-coalescing-operator",
+        "severity": 2,
+      },
+    ],
+    "warningCount": 0,
+  },
   {
     "errorCount": 1,
     "filePath": "<fixture>/src/import-order.js",
@@ -270,22 +295,24 @@ exports[`Core > printDetailsOfResults 1`] = `
 `;
 
 exports[`Core > printSummaryOfResults 1`] = `
-"[1m- 7 files (0 file passed, [91m7 files failed[39m) checked.[22m
-[1m- 18 problems ([31m17 errors[39m, [33m1 warning[39m) found.[22m
-╔═════════════════════════════╤═══════╤═════════╤════════════╤═════════════════╗
-║ Rule                        │ Error │ Warning │ is fixable │ has suggestions ║
-╟─────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
-║ arrow-body-style            │ [31m[1m12[39m[22m    │ 0       │ [31m[1m12[39m[22m         │ 0               ║
-╟─────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
-║ ban-exponentiation-operator │ [31m[1m1[39m[22m     │ 0       │ 0          │ 0               ║
-╟─────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
-║ import/order                │ [31m[1m1[39m[22m     │ 0       │ 0          │ 0               ║
-╟─────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
-║ no-unsafe-negation          │ [31m[1m1[39m[22m     │ 0       │ 0          │ [31m[1m1[39m[22m               ║
-╟─────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
-║ no-unused-vars              │ [31m[1m1[39m[22m     │ 0       │ 0          │ 0               ║
-╟─────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
-║ ]8;;https://example.comprefer-const]8;;                │ [31m[1m1[39m[22m     │ [31m[1m1[39m[22m       │ [31m[1m2[39m[22m          │ 0               ║
-╚═════════════════════════════╧═══════╧═════════╧════════════╧═════════════════╝
+"[1m- 8 files (0 file passed, [91m8 files failed[39m) checked.[22m
+[1m- 19 problems ([31m18 errors[39m, [33m1 warning[39m) found.[22m
+╔══════════════════════════════════════╤═══════╤═════════╤════════════╤═════════════════╗
+║ Rule                                 │ Error │ Warning │ is fixable │ has suggestions ║
+╟──────────────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
+║ arrow-body-style                     │ [31m[1m12[39m[22m    │ 0       │ [31m[1m12[39m[22m         │ 0               ║
+╟──────────────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
+║ ban-exponentiation-operator          │ [31m[1m1[39m[22m     │ 0       │ 0          │ 0               ║
+╟──────────────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
+║ test/ban-nullish-coalescing-operator │ [31m[1m1[39m[22m     │ 0       │ 0          │ 0               ║
+╟──────────────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
+║ import/order                         │ [31m[1m1[39m[22m     │ 0       │ 0          │ 0               ║
+╟──────────────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
+║ no-unsafe-negation                   │ [31m[1m1[39m[22m     │ 0       │ 0          │ [31m[1m1[39m[22m               ║
+╟──────────────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
+║ no-unused-vars                       │ [31m[1m1[39m[22m     │ 0       │ 0          │ 0               ║
+╟──────────────────────────────────────┼───────┼─────────┼────────────┼─────────────────╢
+║ ]8;;https://example.comprefer-const]8;;                         │ [31m[1m1[39m[22m     │ [31m[1m1[39m[22m       │ [31m[1m2[39m[22m          │ 0               ║
+╚══════════════════════════════════════╧═══════╧═════════╧════════════╧═════════════════╝
 "
 `;
diff --git a/src/core.test.ts b/src/core.test.ts
@@ -82,6 +82,9 @@ const iff = await createIFF({
   'src/ban-exponentiation-operator.js': dedent`
     2 ** 2;
   `,
+  'src/ban-nullish-coalescing-operator.js': dedent`
+    2 ?? 2;
+  `,
   'src/no-unused-vars.js': dedent`
     const a = 1;
   `,
@@ -91,18 +94,47 @@ const iff = await createIFF({
   'src/no-unsafe-negation.js': dedent`
     if (!key in object) {}
   `,
+  'node_modules/eslint-plugin-test/package.json': dedent`
+    {
+      "name": "eslint-plugin-test",
+      "version": "1.0.0",
+      "main": "index.js"
+    }
+  `,
+  'node_modules/eslint-plugin-test/index.js': dedent`
+    module.exports = {
+      rules: {
+        'ban-nullish-coalescing-operator': {
+          create(context) {
+            return {
+              LogicalExpression: (node) => {
+                if (node.operator === '??') {
+                  context.report({
+                    node,
+                    message: 'Ban nullish coalescing operator',
+                  });
+                }
+              },
+            };
+          },
+        },
+      },
+    };
+  `,
   '.eslintrc.js': dedent`
     module.exports = {
       root: true,
       parserOptions: {
         ecmaVersion: 2021,
         sourceType: 'module',
       },
+      plugins: ['test'],
       overrides: [
         { files: ['prefer-const.js'], rules: { 'prefer-const': 'error' } },
         { files: ['arrow-body-style.js'], rules: { 'arrow-body-style': ['error', 'always'] } },
         { files: ['import-order.js'], rules: { 'import/order': 'error' } },
         { files: ['ban-exponentiation-operator.js'], rules: { 'ban-exponentiation-operator': 'error' } },
+        { files: ['ban-nullish-coalescing-operator.js'], rules: { 'test/ban-nullish-coalescing-operator': 'error' } },
         {
           files: ['no-unused-vars.js'],
           rules: { 'no-unused-vars': ['error', { varsIgnorePattern: '^_' }] },
@@ -312,4 +344,9 @@ describe('Core', () => {
     expect(await readFile(iff.paths['src/index.jsx'], 'utf-8')).toMatchSnapshot();
     expect(await readFile(iff.paths['src/.index.js'], 'utf-8')).toMatchSnapshot();
   });
+  test('fixes problems with legacy config and 3rd-party plugins', async () => {
+    const results = await core.lint();
+    await core.disablePerLine(results, ['test/ban-nullish-coalescing-operator']);
+    expect(await readFile(iff.paths['src/ban-nullish-coalescing-operator.js'], 'utf-8')).toMatchSnapshot();
+  });
 });