Issue #36 - Twiggy died when client close connection during streaming #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* installing on_error handler * ignoring $writer->write() when handler is closed * added test t/anyevent_closed_streaming_async.t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #36 (a little bit better than PR 39 - #39)
With AnyEvent::Loop (pure perl) Twiggy dies when client close connection during streaming:
AnyEvent::Handle uncaught error: Broken pipe (SIGPIPE)With EV loop implementation, Twiggy produces warning
EV: error in callback (ignoring): AnyEvent::Handle uncaught error: Broken pipe (SIGPIPE)This PR:
on_errorhandler during Twiggy::Writer construction$writer->write()doesn't callpush_writewhen error occurred andon_errorwas calledHowever, the problem with streaming is not completely solved. PSGI specs doesn't specify any interface of the writer object to stop streaming in case of error - see details plack/psgi-specs#27
It can lead to infinite streaming in the worst case.