Suppress 400 if client disconnected (mk 2) #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyagawa
added a commit
that referenced
this pull request
Sep 18, 2011
Suppress 400 if client disconnected (mk 2)
|
Just a thought - is it possible to write a unit test for this? |
|
Sure, I've added one (845ceda) that tests that empty or incomplete-header requests followed by a shutdown(2) call cause Twiggy to not respond with anything. This doesn't cover the case where the client calls close(2), but since both events are seen as PIPE signals on the server side, that should be ok. A test that actually watches the wire with tcpdump or something (which is how I noticed this originally) seems rather more complicated than necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates #18, more correctly this time. This is a new pull requests github didn't pull the latest commit into that one.