Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CachingReader: Reduce log spam for corrupt files #652

Merged
merged 27 commits into from
Jul 28, 2015
Merged

CachingReader: Reduce log spam for corrupt files #652

Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a453bb1
Use an exclusive upper bound for frame indexes
uklotzde Jul 17, 2015
10d1a08
Shorten readable length of corrupt files to avoid repeated decoding
uklotzde Jul 18, 2015
946f914
Add a function to clamp a frame index interval
uklotzde Jul 18, 2015
95686a7
No need to allocate CachingReaderWorker dynamically
uklotzde Jul 18, 2015
5eff211
Define a constant for special hint length values
uklotzde Jul 18, 2015
e86957f
Code cleanups: Consistent naming, remove unncessary checks and local …
uklotzde Jul 18, 2015
e037f3a
Fill sample buffer with zeros if data is unreadable
uklotzde Jul 20, 2015
ed1912f
Add note about outdated/imprecise comment
uklotzde Jul 21, 2015
d86cac0
Fix preroll calculation in CachingReader
uklotzde Jul 23, 2015
4a0c4ca
Delete unused members from cached chunks
uklotzde Jul 23, 2015
5360eb9
Stop reading on errors
uklotzde Jul 23, 2015
f9e1d19
Adjust upper chunk bound on errors
uklotzde Jul 23, 2015
0ec591e
Split CachingReader::read() into 3 phases and add helpful comments
uklotzde Jul 24, 2015
4ea5ec9
Delete obsolete forward declaration
uklotzde Jul 25, 2015
b485ee4
Introduce class CachingReaderChunk
uklotzde Jul 26, 2015
0ecc591
Simplify CachingReader(-Worker) by using CachingReaderChunk
uklotzde Jul 26, 2015
0b5ed8f
Implement fault tolerant seeking
uklotzde Jul 26, 2015
45a0c63
Merge branch 'master' into ReduceLogSpamForCorruptFiles
uklotzde Jul 26, 2015
7c37e39
Split CachingReaderChunk into 2 classes (cache vs. worker)
uklotzde Jul 26, 2015
bdc32ea
Fix some minor review comments
uklotzde Jul 27, 2015
418b4c7
Renaming: CachingReaderChunkWorker -> CachingReaderChunkForWorker
uklotzde Jul 27, 2015
18a1a23
Rename functions for passing control between cache and worker
uklotzde Jul 27, 2015
8c5ac9f
Add more comments to the worker that explain the reading strategy
uklotzde Jul 27, 2015
7bb596e
Re-adjust max. readable frame index after reading
uklotzde Jul 27, 2015
c7a23b7
Disable implicit copy-ctor of CachingReaderChunkForWorker
uklotzde Jul 27, 2015
3ec2db9
Renaming: CachingReaderChunkForWorker/CachingReaderChunkForOwner
uklotzde Jul 28, 2015
ecba2aa
Improve processing of requests in CachingReaderWorker
uklotzde Jul 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/depends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,7 @@ def sources(self, build):
"engine/readaheadmanager.cpp",
"engine/enginetalkoverducking.cpp",
"cachingreader.cpp",
"cachingreaderchunk.cpp",
"cachingreaderworker.cpp",

"analyserrg.cpp",
Expand Down
Loading