Fix outstanding SoundSource issues #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following assertion: DEBUG ASSERT: "0 == (hint.sample % CachingReaderWorker::kChunkChannels)" in file src/cachingreader.cpp, line 492 The calculation of chunk offsets relies on chunks with a constant size. Only the last chunk might be smaller than all others. The worker now fills the chunks with silence if the data has been read partially.
Because of reasons I don't know processChunkReadRequest() is called periodically even while the track is not playing. Unnecessary seek operations on the SoundSource should be avoided for if the frame index is out of range or beyond the end of the file.
|
Thank you very much! |
daschuer
added a commit
that referenced
this pull request
Jun 30, 2015
…eking Fix outstanding SoundSource issues
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes the violation of an implicit assumption if data from corrupt files can only be read partially.
The remaining commits fix an issue reported by synthor in the forums regarding repeated seek operations in files: http://www.mixxx.org/forums/viewtopic.php?f=1&t=7131&start=70#p24740
I've eliminated the unnecessary seek operations, but the CachingReaderWorker is still reading the same chunk over and over even if the track has been stopped. If this is actually an issue it must be fixed for both 1.12 and master.This does only happen at the end of a corrupt file when less data than expected could be read.Fixes https://bugs.launchpad.net/mixxx/+bug/1470049