Highlight Crates a Track is in #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateHighlightDelegate.
Sidebar highlight fixes.
I think this was why we had to add signals to each individual feature.
…selection changes.
This supports bolding/unbolding the playlist/crate when a track is added/removed.
Some fixes.
…/PlaylistDAO. Also add a method to fetch all the playlists/crates a track is in.
Avoids repeatedly asking the DAO for pair-wise membership (requires linear hash table lookups).
This caused severe performance issues since it triggered a repaint on every loop iteration.
|
This won't compile in my tree because of the nullptr references. Is the current master merged in here so that we build with c++11? |
|
works after merging current master in. Also is blazing fast again ;-) LGTM |
|
SGTM, thanks @MK-42 ! |
|
@MK-42 -- you're not in the Mixxx credits yet -- what name would you like to be added? |
|
Oops -- you're in the 1.12 branch but I was looking at master. nevermind! |
|
@rryan you take the wrong guy. There is another one that's not in the credits ;) |
|
@sblaisot oops :) what name would you like in the credits? |
|
@rryan you just have to merge PR606 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of @MK-42's PR #598 with a performance fix.