Writing Tags: Handle inaccessible tags correctly #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observed for some .m4a files when TagLib failed to access (read/write) the existing MP4 tag.
|
|
||
| if (kFileTypeMP3 == fileType) { | ||
| QScopedPointer<TagLib::MPEG::File> pMPEGFile( | ||
| new TagLib::MPEG::File(fileName.toLocal8Bit().constData())); | ||
| bool defaultID3V2 = true; | ||
| if (hasAPETag(*pMPEGFile)) { | ||
| writeTrackMetadataIntoAPETag(pMPEGFile->APETag(), trackMetadata); | ||
| tagWritten |= writeTrackMetadataIntoAPETag(pMPEGFile->APETag(), trackMetadata); |
There was a problem hiding this comment.
This looks like you care about individual bits. On the other hand it is a nice on-liner :-/
Do you actually need to care about the previous state? From a short skim over the code it looks like we are only pass such statement once.
|
The bitwise-or-assignment operator is just the most compact way to collect the results that are needed for the final evaluation. The new name of the boolean variable hopefully reveals the intention better than before. I've also added a separate warning message for each possible error. |
|
Thank you for the fix! LGTM |
daschuer
added a commit
that referenced
this pull request
Apr 28, 2015
Writing Tags: Handle inaccessible tags correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not segfault when trying to write metadata into files with inaccessible tags.
Observed for some .m4a files when TagLib failed to access (read/write) the existing MP4 tag. In this case calling tag() might return 0.
Only relevant when writing metadata into file tags has been enabled.