-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set inital persistant value of COs #559
Conversation
Open discussion form: #534 (comment)
Yes, you are right, there is one, even though in most cases a inital Mixxx start should move its persistent controls to the default value. |
The argument should probably be called defaultValue so people understand it's not just an initial value, and then the header comments should also say that the co will be initialized to the default value on construction. |
Conflicts: src/skin/legacyskinparser.cpp
Names changed, comments added. |
if (m_bPersistInConfiguration) { | ||
ConfigObject<ConfigValue>* pConfig = ControlDoublePrivate::s_pUserConfig; | ||
if (pConfig != NULL) { | ||
// Assume toDouble() returns 0 if conversion fails. | ||
value = pConfig->getValueString(m_key).toDouble(); | ||
initalValue = pConfig->getValueString(m_key).toDouble(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inital -> initial
Just some spelling fixes and a slight rewording of the comment, then LGTM |
I'll do the fixes post merge since I'd like to get this into master before #411. |
Allow to set initial persistant value of COs.
This is a follow up of #534
It removes a hack for setting the initial persistent value, and allows whole Mixxx to benefit from it.