[Not a PR] Replace ChannelHandle/ChannelHandleAndGroup with GroupHandle #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I made a copy in my fork and may adopt this in the future. |
|
Thank you. @Swiftb0y you may also issue a new WIP PR, just to remind us that this work exists. |
|
sure #4843 |
|
Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this as an alternative to #4672 to get rid of the string-typed group handles. It also cleans up the code by getting rid of some redundancies. Worked reliably for me.
For whom it may concern. This PR is only intended as an offer to copy my branch before I finally delete.
You may close this PR when done. Otherwise I will do it eventually.