Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Add a raw version with all PRs towards Mixxx 2.4 #4840

Merged
merged 6 commits into from
Aug 5, 2022

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jul 5, 2022

This is an important step towards the long overdue 2.4 release. We have already integrated ~800 PRs .. Thank you all for this hard work.

The rendered Changelog looks like this:
https://github.com/daschuer/mixxx/blob/9cfe9e4d0f8eacafc4c82be87a352e48c3ad167b/CHANGELOG.md

I like to keep this full list as a commit for later reference, documenting our next meld down step.
So please have a look.

The next step would be cut out a 2.4 branch. I am still very much in favor or a 6 month release cycle to stop wining about a view very last PRs that should become part of a certain release and than delay all the other 800 by another six month or such.

Let's now also collect PRs that should still go to 2.4 at the 2.4 Milestone:
https://github.com/mixxxdj/mixxx/pulls?q=is%3Aopen+is%3Apr+milestone%3A2.4.0

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Jul 5, 2022

  • Implement Un-eject to reload the previous track 4868

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Jul 5, 2022

  • Implement Un-eject to reload the previous track 4868

Oh, that's already added to the "Other" section. Let's move it up so it's easier to discover?

@daschuer
Copy link
Member Author

daschuer commented Jul 6, 2022

I have moved all 2.3.4 changes to #4842

@daschuer daschuer requested a review from ronso0 July 6, 2022 06:01
@daschuer
Copy link
Member Author

This is now rebased on top of current main including the unrelease 2.3.4 changelog.

@daschuer
Copy link
Member Author

@ronso0 this should now also be up to date.

@daschuer daschuer added this to the 2.4.0 milestone Jul 19, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Jul 20, 2022

I took another look, didn't notice anything obvious, though I don't have the concentration to double-check all PRs, and probably also no time for this this week.
Someone else wants to take a look?

@daschuer
Copy link
Member Author

daschuer commented Aug 3, 2022

Anyone else want that want to take a look?

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this tedious job!

Some typos and other minor remarks.
Note I only checked Changelog.md, someone else may do the final check that meatinfo.xml matches

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entries that need to be moved to 2.4

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member

Swiftb0y commented Aug 4, 2022

Note I only checked Changelog.md, someone else may do the final check that meatinfo.xml matches

Not necessary IMO. The metainfo.xml is generated automatically from the changelog.

@daschuer
Copy link
Member Author

daschuer commented Aug 4, 2022

Done

@ronso0
Copy link
Member

ronso0 commented Aug 4, 2022

There are some issues left
#4840 (review)

@ronso0
Copy link
Member

ronso0 commented Aug 5, 2022

Thank you 🎉

@ronso0 ronso0 merged commit d216520 into mixxxdj:main Aug 5, 2022
@daschuer
Copy link
Member Author

daschuer commented Aug 5, 2022

Thank you very much for your thoughtful review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants