Code

Effect crasher fix #4707

Code

Merged

ywwg merged 22 commits intomixxxdj:mainmixxxdj/mixxx:mainfrom daschuer:effects_refactoring_3daschuer/mixxx:effects_refactoring_3Copy head branch name to clipboardNov 3, 2022

+409-476

Commits

Commits on Mar 16, 2022

• Added a TODO for a probably data race in effectprocessor.

  daschuer

  committed
  29fa03b

  Copy full SHA for 29fa03b

• Added a TODO for another probably data race in effectprocessor.

  daschuer

  committed
  36fbe82

  Copy full SHA for 36fbe82

• Remove unused function EnginEffectChain::getChannelStatus()

  daschuer

  committed
  027ddee

  Copy full SHA for 027ddee

• Avoid write access via reference

  daschuer

  committed
  fd60cf9

  Copy full SHA for fd60cf9

• Add ChannelHandleMap::isEmpty()

  daschuer

  committed
  e379844

  Copy full SHA for e379844

Commits on Mar 19, 2022

• Pass ChannelHandleAndGroup instead of just the group name to avoid handle lookup

  daschuer

  committed
  b019fa7

  Copy full SHA for b019fa7

• Move the skin warning before the assertion

  daschuer

  committed
  f5bb9a1

  Copy full SHA for f5bb9a1

• Enable the effects AFTER we have added effect slots

  daschuer

  committed
  5663ae2

  Copy full SHA for 5663ae2

Commits on Mar 23, 2022

• extend scope for a better readability

  daschuer

  committed
  895a7e8

  Copy full SHA for 895a7e8

Commits on Mar 29, 2022

• Introduce an updateActiveState() function to be able to clean up buffers after a channel has been disabled.

  daschuer

  committed
  2d2bb6c

  Copy full SHA for 2d2bb6c

• process one more buffer after eject

  daschuer

  committed
  dff90d2

  Copy full SHA for dff90d2

• Use the fadeout flag to fade down and initialize the effect buffers when a stream is paused. Fixes lp1966607

  daschuer

  committed
  bf1af79

  Copy full SHA for bf1af79

• EffectProcessor: split out initalizeChannelHandle

  daschuer

  committed
  313d4ab

  Copy full SHA for 313d4ab

• Don't delete effect state object when chain is disabled. From the user perspective it is no difference between disabling an effect or a chain.

  daschuer

  committed
  c4b081a

  Copy full SHA for c4b081a

Commits on Mar 30, 2022

• Use override keyword

  daschuer

  committed
  b4dc449

  Copy full SHA for b4dc449

Commits on Apr 3, 2022

• Manage the lifetime of the effect state by a std::unique_ptr

  daschuer

  committed
  2250eaa

  Copy full SHA for 2250eaa

Commits on Jul 19, 2022

• Merge remote-tracking branch 'upstream/main' into effects_refactoring_3

  daschuer

  committed
  27dd095

  Copy full SHA for 27dd095

Commits on Jul 22, 2022

• Added missing null check in CueControl::hintReader()

  Show description for cba84c1
  daschuer

  committed
  cba84c1

  Copy full SHA for cba84c1

Commits on Oct 28, 2022

• re-enabble debug guard

  daschuer

  committed
  5d63ac3

  Copy full SHA for 5d63ac3

• Introduce kInitalSamplerRate to use before the SoundDevice is set up

  daschuer

  committed
  b504c61

  Copy full SHA for b504c61

• Avoid confusing handle().handle() code

  daschuer

  committed
  3528e4c

  Copy full SHA for 3528e4c

• Added missing final keyword

  daschuer

  committed
  8d133e6

  Copy full SHA for 8d133e6