PlayerManager: Move duplicate code into function in anonymous namespace #4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
force-pushed
the
playermanager-deduplicate-nextfreeplayer
branch
from
6dcec20 to
90f60bc
Compare
Swiftb0y
reviewed
Dec 25, 2021
| /// the corresponding `play` CO is set to 0. | ||
| template<class T> | ||
| T* findFirstStoppedPlayerInList(const QList<T*>& players) { | ||
| for (T* pPlayer : players) { |
There was a problem hiding this comment.
this could be const if BasePlayer::getGroup() was const (which it should be IMO).
There was a problem hiding this comment.
Do you mean this?
Suggested change
| for (T* pPlayer : players) { | |
| for (const T* pPlayer : players) { |
This does not work, because in that case the return type would also have to be const. This would severly limit what you can do with the result (or you'd need to use const_cast which I consider a terrible hack).
There was a problem hiding this comment.
Good point. I didn't think about that. LGTM me then.
Holzhaus
force-pushed
the
playermanager-deduplicate-nextfreeplayer
branch
from
90f60bc to
d898e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.