Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MixxxApplication: guard registerComparators behind Qt verison check #4404

Merged
merged 1 commit into from
Oct 13, 2021
Merged

MixxxApplication: guard registerComparators behind Qt verison check #4404

merged 1 commit into from
Oct 13, 2021

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Oct 13, 2021

registerComparators was removed in Qt6 and is no longer needed:
https://doc.qt.io/qt-6/qtcore-changes-qt6.html#the-qmetatype-class

uklotzde
uklotzde approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 6c15c2c into mixxxdj:main Oct 13, 2021
@Be-ing Be-ing deleted the registercomparitors branch October 13, 2021 16:07
@daschuer daschuer mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Qt6
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @uklotzde