BeatGrid::makeBeatGrid(): Delete debug assertion #4261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we know where the call originates? That code should call The debug assertion is supposed to protect against the case where after ejecting/reloading the track the beatgrid is suddenly a bit shifted because the original position was fractional and rounded by the integer conversion. |
|
Invoked by BeatFactory::makePreferredBeats() with BEAT_GRID_2_VERSION. The position is the result of BeatUtils::makeConstBpm() (modifies firstBeat) and then BeatUtils::adjustPhase(). |
Holzhaus
added a commit
to Holzhaus/mixxx
that referenced
this pull request
Sep 4, 2021
Due to our interal beatgrid storage format, fractional beat positions are not allowed. Fixes https://github.com/mixxxdj/mixxx/pull/4258/files#r702285221. Alternative to mixxxdj#4261.
Holzhaus
added a commit
to Holzhaus/mixxx
that referenced
this pull request
Sep 4, 2021
Due to our internal beatgrid storage format, fractional beat positions are not allowed. Fixes https://github.com/mixxxdj/mixxx/pull/4258/files#r702285221. Alternative to mixxxdj#4261.
|
Please have a look at: #4263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily fixes https://github.com/mixxxdj/mixxx/pull/4258/files#r702285221