Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Trigger automatic update of manual repo if CHANGELOG.md was changed #4180

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Aug 5, 2021

See corresponding PR mixxxdj/manual#422 for details.

This requires a Personal Acess Token (PAT) with the public_repo scope
in the repository secrets (named MANUAL_REPO_TOKEN).

@Holzhaus Holzhaus force-pushed the changelog-autoupdater branch from a9055c1 to 0711adc Compare August 5, 2021 14:56
@ywwg
Copy link
Member

ywwg commented Aug 5, 2021

this is very helpful! thank you

@ywwg
Copy link
Member

ywwg commented Aug 5, 2021

(I don't know yaml so I can't review)

@Holzhaus
Copy link
Member Author

Holzhaus commented Aug 7, 2021

Well, this PR is just s github workflow that should trigger another workflow on the manual repo. The other PR contains some python code if you want to review that.

@uklotzde
Copy link
Contributor

uklotzde commented Aug 8, 2021

Can we merge before mixxxdj/manual#422 has been merged?

@Holzhaus
Copy link
Member Author

Holzhaus commented Aug 8, 2021

Can we merge before mixxxdj/manual#422 has been merged?

I don't think it makes sense. Either it makes no difference or it results in a failing check every time we update the changelog.

@Swiftb0y
Copy link
Member

@Holzhaus I think you messed up a merge or you are targeting the wrong branch...

See corresponding PR mixxxdj/manual#422 for details.

This requires a Personal Acess Token (PAT) with the `public_repo` scope
in the repository secrets (named `MIXXXBOT_CHANGELOG_AUTOUPDATER_PAT`).
@Holzhaus Holzhaus force-pushed the changelog-autoupdater branch from 5caba63 to a9c859a Compare August 16, 2021 15:36
@Holzhaus
Copy link
Member Author

Oops, accidently rebased on main. Fixed.

@Be-ing
Copy link
Contributor

Be-ing commented Aug 29, 2021

Is there anything left to do here?

@Holzhaus
Copy link
Member Author

No, but this PR only triggers a workflow run on the manual repo, so the PR on the manual repo should be merged first.

@Holzhaus Holzhaus merged commit 41a05ee into mixxxdj:2.3 Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants