Beats: Remove unnecessary capabilities #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have two beats implementations (`BeatGrid` and `BeatMap`) and both support scaling and translating. Hence, it's unnecessary to maintain these flags. In fact, the `BEATSCAP_SCALE` capability wasn't even checked in the calling code but nobody noticed because both support it anyway. The `BEATSCAP_ADDREMOVE` and `BEATSCAP_MOVEBEAT` capabilities are only supported by the `BeatMap`, but we don't have any code that makes use of them. Therefore, these can be removed as well.
Holzhaus
force-pushed
the
remove-beatscap-scale-translate
branch
from
baa5fbd to
6a95caa
Compare
Pull Request Test Coverage Report for Build 1024416249
💛 - Coveralls |
|
Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have two beats implementations (
BeatGridandBeatMap)and both support scaling and translating. Hence, it's unnecessary to
maintain these flags. In fact, the
BEATSCAP_SCALEcapability wasn'teven checked in the calling code but nobody noticed because both support
it anyway.
The
BEATSCAP_ADDREMOVEandBEATSCAP_MOVEBEATcapabilities are onlysupported by the
BeatMap, but we don't have any code that makes use ofthem. Therefore, these can be removed as well