Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some debian dependencies for the new QML skin #3961

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jun 7, 2021

Unfortunatly the QMLDemo skin does still not load on Ubuntu Groovy (Qt 5.12):

info [Main] Loaded skin "QMLDemo"
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/main.qml:54:9: Type Skin.DeckRow unavailable 
             Skin.DeckRow { 
             ^
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/DeckRow.qml:71:5: Type Deck unavailable 
         Deck { 
         ^
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/Deck.qml:25:5: Type Skin.ControlSlider unavailable 
         Skin.ControlSlider { 
         ^
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/ControlSlider.qml:5:1: Type Skin.Slider unavailable 
     Skin.Slider { 
     ^
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/Slider.qml:7:1: Type MixxxControls.Slider unavailable 
     MixxxControls.Slider { 
     ^
warning [Main] file:///home/sperry/workspace/mixxx/res/skins/QMLDemo/Mixxx/Controls/Slider.qml:9:31: Invalid alias target location: margins 
         property alias barMargin: barShape.anchors.margins 
                                   ^
warning [Main] Skin "QMLDemo" failed to load!

Is something else missing?

@github-actions github-actions bot added the build label Jun 7, 2021
@@ -84,5 +84,9 @@ case "$COMMAND" in
protobuf-compiler \
qt5keychain-dev \
qtdeclarative5-dev \
qml-module-qtquick-controls \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Fedora it's just qt5-qtquickcontrols + qt5-qtquickcontrols2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I didn't install any additional dependencies on Arch. Just qt5-declarative.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both qt5-qtquickcontrols and qt5-qtquickcontrols2 are installed on my system. Maybe they are not needed? I need to check this with a mock build sometime.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The probably are. Apparently qt5-quickcontrols and qt5-quickcontrols2 were installed automatically or something.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least they are not required for qt5-declarative. If we need them we have to install them explicitly.

@uklotzde uklotzde changed the title Added some debian debendencies for the new QML skin Added some debian dependencies for the new QML skin Jun 7, 2021
@Holzhaus
Copy link
Member

Holzhaus commented Jun 7, 2021

Apparently aliasing associated properties in QML has been added in Qt > 5.12.

I tried to write a "smoke test" for QML skins, but since skins require COs, this basically forces me to reimplement the whole MixxxMainWindow constructor in a test. We should definitely split QWisgets/UI stuff off to make that usable in a test.

@Holzhaus
Copy link
Member

Holzhaus commented Jun 7, 2021

I tried to write a "smoke test" for QML skins, but since skins require COs, this basically forces me to reimplement the whole MixxxMainWindow constructor in a test. We should definitely split QWisgets/UI stuff off to make that usable in a test.

I give up.

If someone else wants to take a stab as this: https://github.com/mixxxdj/mixxx/compare/main...Holzhaus:qmlskintest?expand=1

@daschuer
Copy link
Member Author

daschuer commented Jun 7, 2021

Currently I cannot test the new QML skin because of the debug message above.
It there a way to make it work for example by comment out the parts that requires qt 5.14?

By the way this PR was created by installing the packages Mixxx was prompting me when rejecting the QMLDeno and fall back to default.

@Swiftb0y
Copy link
Member

Swiftb0y commented Jun 7, 2021

@daschuer the issue you are experiencing should be fixed by #3963

@Holzhaus Holzhaus merged commit 2794d35 into mixxxdj:main Jun 8, 2021
@daschuer daschuer deleted the qml_debian branch August 1, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants