-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some debian dependencies for the new QML skin #3961
Conversation
@@ -84,5 +84,9 @@ case "$COMMAND" in | |||
protobuf-compiler \ | |||
qt5keychain-dev \ | |||
qtdeclarative5-dev \ | |||
qml-module-qtquick-controls \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Fedora it's just qt5-qtquickcontrols + qt5-qtquickcontrols2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I didn't install any additional dependencies on Arch. Just qt5-declarative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both qt5-qtquickcontrols and qt5-qtquickcontrols2 are installed on my system. Maybe they are not needed? I need to check this with a mock build sometime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The probably are. Apparently qt5-quickcontrols and qt5-quickcontrols2 were installed automatically or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least they are not required for qt5-declarative. If we need them we have to install them explicitly.
Apparently aliasing associated properties in QML has been added in Qt > 5.12. I tried to write a "smoke test" for QML skins, but since skins require COs, this basically forces me to reimplement the whole MixxxMainWindow constructor in a test. We should definitely split QWisgets/UI stuff off to make that usable in a test. |
I give up. If someone else wants to take a stab as this: https://github.com/mixxxdj/mixxx/compare/main...Holzhaus:qmlskintest?expand=1 |
Currently I cannot test the new QML skin because of the debug message above. By the way this PR was created by installing the packages Mixxx was prompting me when rejecting the QMLDeno and fall back to default. |
Unfortunatly the QMLDemo skin does still not load on Ubuntu Groovy (Qt 5.12):
Is something else missing?