Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skins/QMLSkin: Add support for maximized library #3937

Merged
merged 5 commits into from
Jun 4, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Jun 3, 2021

It's not connected to the CO yet, because that CO is skin-created.

@github-actions github-actions bot added the skins label Jun 3, 2021
@Swiftb0y
Copy link
Member

Swiftb0y commented Jun 4, 2021

I'm unsure whether I like this Minideck approach. If there was only a deck that selectively scales and hides its controls it would result in a much better animation.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I really like the animation of the mixer.

property Item fadeTarget

SequentialAnimation {
NumberAnimation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming you don't need to access the opacity during the animation, you can try to use an OpacityAnimator instead. Not sure if that works when used as a value interceptor like in this case though...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to try that out, feel free to do that in a follow up. I struggled far too long with these animations (I initially planned to reanchor the cue/play button and the overview, too), but didn't manage to make it look good.

res/skins/QMLDemo/InfoBarButton.qml Outdated Show resolved Hide resolved
res/skins/QMLDemo/MiniDeckRow.qml Outdated Show resolved Hide resolved
duration: 150
}

PropertyAction {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you've taken this code from some example code on the Behavior Type but I still struggle to understand it...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

}

},
State {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to deduplicate this State by making the first one reversible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment why this is not possible.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience. I'll go ahead and merge.

@Swiftb0y Swiftb0y merged commit 3a81904 into mixxxdj:main Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants