Revert end of track #3867
Revert end of track #3867
Conversation
There was a problem hiding this comment.
Thanks, this works for me.
However, there is still some other issue, because the tone of the playing deck changes when I right-click the sync button on the other deck: https://www.youtube.com/watch?v=_bsrPJ6I6Gc I didn't notice that before #3698 was merged.
src/engine/sync/synccontrol.cpp
Outdated
| @@ -14,6 +14,8 @@ | |||
| #include "util/logger.h" | |||
| #include "util/math.h" | |||
|
|
|||
| const double kTrackPositionMasterHandoff = 0.99; | |||
There was a problem hiding this comment.
What's the reason for this cutoff instead of using the actual end? Just wondering, because 0.01 can be very different of a 2 minute track compared to a premixed 2 hour set.
There was a problem hiding this comment.
@ywwg Please comment those decisions for others and your future self. Otherwise no one will able to reason why this particular value has been chosen.
There was a problem hiding this comment.
that's a good point. I think I was worried about a case where we hit 1.0 and the deck stops before the handoff occurs. I think that's not an issue though
I can't see the other deck in your capture so I'm not quite sure what you're talking about. Can you record again with a less wide window? |
Yeah sorry, I only noticed after upload. The only thing you can't see is that I right-click the "SYNC" button on deck B multiple times to make it explicit leader (and you can hear it, because there's audible key change of the deck A in that case). |
|
I don't think this specific PR causes the pitch issue, can I address that in a separate bug fix? |
|
Ah, the problem is that when you set the stopped track as explicit leader, it resets the beat distance value and the playing track changes speed briefly to resync. |
|
Ooof yes the pitch issues you found are real, but definitely not related to this fix. I am working hard on them elsewhere, but I'd like to merge this to fix the problem of explicit leader getting stuck |
Restore auto-disabling of explicit leader at end of track