Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show the menubar after replacing the launch image #3862

Merged
merged 1 commit into from
May 15, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented May 14, 2021

@Holzhaus In #3839 I was wrong with showing the menubar earlier because I totally missed that loading the skin != showing the skin.
Currently the menubar is shown for a very short period before the skin widget is shown setCentralWidget(m_pWidgetParent);, thus the launch image is shifted downwards before it is replaced by the skin.

@ronso0 ronso0 added the ui label May 14, 2021
@ronso0 ronso0 added this to the 2.3.0 milestone May 14, 2021
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Holzhaus Holzhaus merged commit f16451e into mixxxdj:2.3 May 15, 2021
@ronso0 ronso0 deleted the menubar-launch-skin branch May 15, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants