Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and clean up .gitignore #3861

Merged
merged 5 commits into from
May 24, 2021
Merged

Update and clean up .gitignore #3861

merged 5 commits into from
May 24, 2021

Conversation

uklotzde
Copy link
Contributor

No description provided.

@uklotzde uklotzde added this to the 2.4.0 milestone May 14, 2021
.gitignore Outdated Show resolved Hide resolved
@JoergAtGithub
Copy link
Member

.vs is generated with every build on Windows, but no file in this directory should go in version control, like pre complied headers, build configuration

@uklotzde
Copy link
Contributor Author

uklotzde commented May 14, 2021

.vs is generated with every build on Windows, but no file in this directory should go in version control, like pre complied headers, build configuration

Please add this to your global .gitignore as the top-level comment states. We will not add excludes for every possible IDE out there.

@JoergAtGithub
Copy link
Member

This is not only IDE, but the each Mixxx build generate them. Everybody on Windows is affected!

@Holzhaus
Copy link
Member

I'm pretty sure I didn't see this when running CMake from the command line on windows. Are you sure?

@JoergAtGithub
Copy link
Member

If you build with pre-compiled headers, they are stored in this directory

@uklotzde
Copy link
Contributor Author

uklotzde commented May 14, 2021

If you build with pre-compiled headers, they are stored in this directory

Command-line or IDE? IDE builds are your own responsibility. All CMake build artifacts are already excluded by the /build directory.

@JoergAtGithub
Copy link
Member

It's build from IDE without any settings from another source than CMake. It's nothing custom in my environment. This folder appears for every developer who builds locally following the Mixxx build instructions. And it doesn't contain anything that should go into version control.
Please don't break working things!

@uklotzde
Copy link
Contributor Author

@JoergAtGithub As expected, you confirmed that it is generated by Visual Studio. The same applies to .vscode and .idea folders generated by other IDEs. Those excludes belong into your global .gitignore and are not supposed to be repeated in every project.

I am aware that many projects are doing this wrong and cluttering their .gitignore even with .DS_Store entries.

@Holzhaus
Copy link
Member

@JoergAtGithub https://openqa-bites.github.io/posts/2021-04-23-global-gitignore/

@uklotzde
Copy link
Contributor Author

Ping

@Holzhaus Holzhaus merged commit df1fd52 into mixxxdj:main May 24, 2021
@uklotzde uklotzde deleted the gitignore branch May 24, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants