-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and clean up .gitignore #3861
Conversation
.vs is generated with every build on Windows, but no file in this directory should go in version control, like pre complied headers, build configuration |
Please add this to your global .gitignore as the top-level comment states. We will not add excludes for every possible IDE out there. |
This is not only IDE, but the each Mixxx build generate them. Everybody on Windows is affected! |
I'm pretty sure I didn't see this when running CMake from the command line on windows. Are you sure? |
If you build with pre-compiled headers, they are stored in this directory |
Command-line or IDE? IDE builds are your own responsibility. All CMake build artifacts are already excluded by the /build directory. |
It's build from IDE without any settings from another source than CMake. It's nothing custom in my environment. This folder appears for every developer who builds locally following the Mixxx build instructions. And it doesn't contain anything that should go into version control. |
@JoergAtGithub As expected, you confirmed that it is generated by Visual Studio. The same applies to .vscode and .idea folders generated by other IDEs. Those excludes belong into your global .gitignore and are not supposed to be repeated in every project. I am aware that many projects are doing this wrong and cluttering their .gitignore even with .DS_Store entries. |
Ping |
No description provided.