Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track: Return a copy of TrackMetadata/TrackRecord #3860

Merged
merged 2 commits into from
May 15, 2021
Merged

Track: Return a copy of TrackMetadata/TrackRecord #3860

merged 2 commits into from
May 15, 2021

Conversation

uklotzde
Copy link
Contributor

TrackMetadata and TrackRecord are both movable and can be returned efficiently using copy elision.

https://en.cppreference.com/w/cpp/language/copy_elision

@uklotzde uklotzde added this to the 2.4.0 milestone May 14, 2021
uklotzde added 2 commits May 14, 2021 20:26
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@Holzhaus Holzhaus merged commit f535572 into mixxxdj:main May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants