Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WMainMenuBar: Fix duplicate signal/slot connections #3852

Merged
merged 1 commit into from
May 11, 2021
Merged

WMainMenuBar: Fix duplicate signal/slot connections #3852

merged 1 commit into from
May 11, 2021

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde added this to the 2.3.0 milestone May 11, 2021
@uklotzde uklotzde requested review from Holzhaus and ronso0 May 11, 2021 19:48
@ronso0
Copy link
Member

ronso0 commented May 11, 2021

Thanks!
everything looks nice, shortcuts work when starting windowed or fullscreen and after toggling fullscreen repeatedly (on Linux where the reconnect part is issued).

@ronso0 ronso0 merged commit 772b110 into mixxxdj:2.3 May 11, 2021
@uklotzde uklotzde deleted the wmainmenubar-connections branch May 11, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Awaiting requested review from Holzhaus

@ronso0 ronso0 Awaiting requested review from ronso0

Assignees
No one assigned
Labels
major bug ui
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @ronso0