-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CMAKE_PROJECT_VERSION for URLs #3831
Conversation
Converted to draft for further discussion, because we first need to decide how we want to deal with the |
Thank you. This works for me. |
These files:
However, we do not change the CMAKE_PROJECT_VERSION that often (we're talking about months). Therefore I consider this neglible.
This would also move the URL construction into the runtime domain rather than compile time. I'm not worried about the performance impact (I'm pretty sure that's neglible), but it will mean we need some more refactoring which i'd like to avoid right now. It would also create more conflicts with #3047 (although that PR still has some issues that need to be solved). |
e408db2
to
0eb2b0e
Compare
No idea why this displays as failed, the build works fine. Anyway, this also part of #3841. |
This replaces #3792 by using the existing MIXXX_VERSION_MAJOR and MIXXX_VERSION_MINOR compile definitions.
@daschuer I opened this PR because I'm not that good with explaining my ideas, and it's easier to grasp the idea when looking at code rather. This change is what I meant with my second point here: #3822 (comment)