Code

Reworked beat_active control:#3608

Code

Merged

daschuer merged 18 commits intomixxxdj:mainmixxxdj/mixxx:mainfrom JoergAtGithub:improve_beat_indicatorJoergAtGithub/mixxx:improve_beat_indicatorCopy head branch name to clipboardMar 20, 2021

+275-57

Commits

Commits on Jan 31, 2021

• Reworked beat_active control:

  Show description for 4719d5e
  JoergAtGithub

  committed
  4719d5e

  Copy full SHA for 4719d5e

Commits on Feb 21, 2021

• Added switch, to select if findPrevNextBeats should compare with or without tolerance epsilon

  JoergAtGithub

  committed
  143f255

  Copy full SHA for 143f255

• Added testcases for NoTolerance mode of findPrevNextBeats

  JoergAtGithub

  committed
  1e6d066

  Copy full SHA for 1e6d066

• Merge remote-tracking branch 'upstream/main' into improve_beat_indicator

  JoergAtGithub

  committed
  f8c60f3

  Copy full SHA for f8c60f3

• Improved if cases for NoTolerance code in findPrevNextBeats

  JoergAtGithub

  committed
  1a8f2c2

  Copy full SHA for 1a8f2c2

Commits on Feb 22, 2021

• Merge remote-tracking branch 'upstream/main' into improve_beat_indicator

  JoergAtGithub

  committed
  d407101

  Copy full SHA for d407101

Commits on Feb 23, 2021

• Merge remote-tracking branch 'upstream/main' into improve_beat_indicator

  JoergAtGithub

  committed
  92c48ce

  Copy full SHA for 92c48ce

Commits on Feb 27, 2021

• Moved the 5 states into an internal state machine

  Show description for 5cb6696
  JoergAtGithub

  committed
  5cb6696

  Copy full SHA for 5cb6696

• Added the loop cases:

  Show description for dd1b2b1
  JoergAtGithub

  committed
  dd1b2b1

  Copy full SHA for dd1b2b1

Commits on Mar 1, 2021

• Removed getBeatContextNoLookup() by using findPrevNextBeats without tolerance/snap behavior

  JoergAtGithub

  committed
  6adb30c

  Copy full SHA for 6adb30c

• Renamed NoTolerance to snapToNearBeats and inverted the bool, to match the new term

  JoergAtGithub

  committed
  8b88974

  Copy full SHA for 8b88974

Commits on Mar 2, 2021

• const -> constexpr

  JoergAtGithub

  committed
  93feabe

  Copy full SHA for 93feabe

• Added ToDo comment about moving the updateIndicators to waveform update loop.

  JoergAtGithub

  committed
  fd64411

  Copy full SHA for fd64411

Commits on Mar 5, 2021

• Handled the cue point case. Don't show beat indication after (hot) cue button press.

  JoergAtGithub

  committed
  c3493ea

  Copy full SHA for c3493ea

• Changed reverse beat indication state from -1 to +2

  JoergAtGithub

  committed
  d7ab0d0

  Copy full SHA for d7ab0d0

• Merge branch 'main' into improve_beat_indicator

  JoergAtGithub

  authored
  9a00a1e

  Copy full SHA for 9a00a1e

• pre-commit

  JoergAtGithub

  committed
  f04c35a

  Copy full SHA for f04c35a

Commits on Mar 6, 2021

• Improved responsiveness when pressing play/cue button at while track is hold on a beat

  JoergAtGithub

  committed
  277ed26

  Copy full SHA for 277ed26