Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denon cue stop fix #3546

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Denon cue stop fix #3546

merged 1 commit into from
Jan 10, 2021

Conversation

daschuer
Copy link
Member

@uklotzde uklotzde added this to the 2.3.0 milestone Jan 10, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Jan 10, 2021

Thank you for the quick fix. This confused me a lot playing last night. We should have tests for all the cue modes. This code is very complicated and fairly hard to understand.

@Be-ing Be-ing merged commit 6727e5e into mixxxdj:2.3 Jan 10, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Jan 10, 2021

Please fix the merge conflict with main. I do not know how to fix it due to the aforementioned complexity.

@daschuer daschuer deleted the denon_cue_stop branch September 26, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
major bug
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daschuer @Be-ing @uklotzde