Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EQ Rack #330

Closed
wants to merge 90 commits into from
Closed

EQ Rack #330

wants to merge 90 commits into from

Commits on May 20, 2014

  1. Add eqeffect.cpp to sources list

    @badescunicu
    badescunicu committed May 20, 2014
    Configuration menu
    Copy the full SHA
    bbf6999 View commit details
    Browse the repository at this point in the history

  2. Create an effect with a 3 band EQ

    @badescunicu
    badescunicu committed May 20, 2014
    Configuration menu
    Copy the full SHA
    458b8b7 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2014

  1. Register EqEffect

    @badescunicu
    badescunicu committed May 21, 2014
    Configuration menu
    Copy the full SHA
    d91b153 View commit details
    Browse the repository at this point in the history

  2. Fix comment

    @badescunicu
    badescunicu committed May 21, 2014
    Configuration menu
    Copy the full SHA
    4c0d2fb View commit details
    Browse the repository at this point in the history

  3. [Coding Style] Each member of a class should be on its own line

    @badescunicu
    badescunicu committed May 21, 2014
    Configuration menu
    Copy the full SHA
    5781325 View commit details
    Browse the repository at this point in the history

  4. Remove the link between the super knob and eq knobs

    @badescunicu
    badescunicu committed May 21, 2014
    Configuration menu
    Copy the full SHA
    2a4b063 View commit details
    Browse the repository at this point in the history

  5. Use the initializer list for old_low, old_mid, old_high, old_dry

    @badescunicu
    badescunicu committed May 21, 2014
    Configuration menu
    Copy the full SHA
    1299acb View commit details
    Browse the repository at this point in the history

Commits on May 23, 2014

  1. Use a ControlObjectSlave to get the sample rate from the EqEffect

    @badescunicu
    badescunicu committed May 23, 2014
    Configuration menu
    Copy the full SHA
    5cb622f View commit details
    Browse the repository at this point in the history

  2. Make the sample rate accessible from descendants of GroupEffectProcessor

    @badescunicu
    badescunicu committed May 23, 2014
    Configuration menu
    Copy the full SHA
    dd092b6 View commit details
    Browse the repository at this point in the history

  3. Connect the frequency corners from preferences to the EQ Effect

    @badescunicu
    badescunicu committed May 23, 2014
    Configuration menu
    Copy the full SHA
    e46bf37 View commit details
    Browse the repository at this point in the history

  4. Initialize m_loFreq and m_hiFreq with 0 in initializer list

    @badescunicu
    badescunicu committed May 23, 2014
    Configuration menu
    Copy the full SHA
    def4866 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2014

  1. Fix typo in control.h

    @badescunicu
    badescunicu committed May 24, 2014
    Configuration menu
    Copy the full SHA
    16f52cb View commit details
    Browse the repository at this point in the history

Commits on May 30, 2014

  1. Do ramping after setFrequencyCorners() (not working properly yet)

    @badescunicu
    badescunicu committed May 30, 2014
    Configuration menu
    Copy the full SHA
    2589688 View commit details
    Browse the repository at this point in the history

  2. Do a cross fade without using an additional buffer (not working prope… 

    …rly yet)
    @badescunicu
    badescunicu committed May 30, 2014
    Configuration menu
    Copy the full SHA
    ee31d2e View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2014

  1. Do not create new filters in setFilters(). Update previously created … 

    …filters instead.
    @badescunicu
    badescunicu committed Jun 1, 2014
    Configuration menu
    Copy the full SHA
    d49aaa8 View commit details
    Browse the repository at this point in the history

  2. Change the sample rate in setFrequencyCorners(). If frequency corners… 

    … are changed, do ramping in the next process() call
    @badescunicu
    badescunicu committed Jun 1, 2014
    Configuration menu
    Copy the full SHA
    8859eff View commit details
    Browse the repository at this point in the history

  3. Pass the sample rate to setFrequencyCorners()

    @badescunicu
    badescunicu committed Jun 1, 2014
    Configuration menu
    Copy the full SHA
    03bdf87 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2014

  1. Use memset and memcpy for copying and initializing buffers

    @badescunicu
    badescunicu committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    5890140 View commit details
    Browse the repository at this point in the history

  2. Rename EqEffect to EQDefault

    @badescunicu
    badescunicu committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    199146a View commit details
    Browse the repository at this point in the history

  3. Rename EQ knobs to LOW, MID and HIGH

    @badescunicu
    badescunicu committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    4752eba View commit details
    Browse the repository at this point in the history

  4. Add descriptions to Default EQ and remove redundant includes

    @badescunicu
    badescunicu committed Jun 2, 2014
    Configuration menu
    Copy the full SHA
    2d878c4 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2014

  1. Attempt at switch type parameters

    @badescunicu
    badescunicu committed Jun 6, 2014
    Configuration menu
    Copy the full SHA
    ab66eee View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2014

  1. Update the underlying EffectParameter separately for each type of par… 

    …ameter
    @badescunicu
    badescunicu committed Jun 16, 2014
    Configuration menu
    Copy the full SHA
    a61f12a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2014

  1. Fix typo in computing m_maximum

    @badescunicu
    badescunicu committed Jun 17, 2014
    Configuration menu
    Copy the full SHA
    df366e2 View commit details
    Browse the repository at this point in the history

  2. Correct mistake in effectbuttonparameterslot

    @badescunicu
    badescunicu committed Jun 17, 2014
    Configuration menu
    Copy the full SHA
    25559ed View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2014

  1. Add a new EffectRack with 4 EQDefault effects. Each EQ is responsible… 

    … for a specific Channel
    @badescunicu
    badescunicu committed Jun 19, 2014
    Configuration menu
    Copy the full SHA
    50ee860 View commit details
    Browse the repository at this point in the history

  2. Fix comments

    @badescunicu
    badescunicu committed Jun 19, 2014
    Configuration menu
    Copy the full SHA
    7122847 View commit details
    Browse the repository at this point in the history

  3. Dynamic creation of EQ (each time a deck is added)

    @badescunicu
    badescunicu committed Jun 19, 2014
    Configuration menu
    Copy the full SHA
    ee07447 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2014

  1. Pack the creation of a new EQ inside a method of EffectsManager

    @badescunicu
    badescunicu committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    574d8ea View commit details
    Browse the repository at this point in the history

  2. Minor coding style improvement

    @badescunicu
    badescunicu committed Jun 20, 2014
    Configuration menu
    Copy the full SHA
    0c9dabc View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2014

  1. Fix createElement argument in effect.cpp

    @badescunicu
    badescunicu committed Jun 22, 2014
    Configuration menu
    Copy the full SHA
    f0bfd6f View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2014

  1. Add 4 check boxes for controlling which effect to load onto the EQ Ef… 

    …fectRack
    @badescunicu
    badescunicu committed Jun 26, 2014
    Configuration menu
    Copy the full SHA
    66bb4ed View commit details
    Browse the repository at this point in the history

  2. Pass a pointer to the EffectsManager to DlgPreferences

    @badescunicu
    badescunicu committed Jun 26, 2014
    Configuration menu
    Copy the full SHA
    e8dcab8 View commit details
    Browse the repository at this point in the history

  3. Update the Effects loaded onto the Rack when the user checks a box

    @badescunicu
    badescunicu committed Jun 26, 2014
    Configuration menu
    Copy the full SHA
    4bf1845 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2014

  1. Use ControlObjectSlave instead of ControlObjectThread for setting the… 

    … effect active and fully wet for a specific deck
    @badescunicu
    badescunicu committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    9aeb025 View commit details
    Browse the repository at this point in the history

  2. Add a slot inside EffectRack for loading an effect on an given effect… 

    … slot of specific chain slot
    @badescunicu
    badescunicu committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    e6f9f4d View commit details
    Browse the repository at this point in the history

  3. Add an EffectRack* and initialize it

    @badescunicu
    badescunicu committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    06d34aa View commit details
    Browse the repository at this point in the history

  4. Create a new signal in dlgprefeq and connect it to a slot of the EQ R… 

    …ack; use this signal whenever a change is made in preferences
    @badescunicu
    badescunicu committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    615d2e9 View commit details
    Browse the repository at this point in the history

  5. Remove the connection for CheckBoxes

    @badescunicu
    badescunicu committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    c463b8f View commit details
    Browse the repository at this point in the history

  6. Create a slot inside dlgprefeq.cpp for dynamically creating ComboBoxes

    @badescunicu
    badescunicu committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    2b18b73 View commit details
    Browse the repository at this point in the history

  7. Temporary hack for having access to DlgPrefEQ

    @badescunicu
    badescunicu committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    b87b610 View commit details
    Browse the repository at this point in the history

  8. Add another ComboBox if the number of decks has increased

    @badescunicu
    badescunicu committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    2f30f76 View commit details
    Browse the repository at this point in the history

  9. Remove the hard coded check boxes

    @badescunicu
    badescunicu committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    7a03def View commit details
    Browse the repository at this point in the history

  10. Dynamically update the required Deck with the selected Effect

    @badescunicu
    badescunicu committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    eeb35dc View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2014

  1. Delete used QComboBoxes in destructor

    @badescunicu
    badescunicu committed Jun 28, 2014
    Configuration menu
    Copy the full SHA
    5cda4b7 View commit details
    Browse the repository at this point in the history

  2. Check if qobject_cast was successful

    @badescunicu
    badescunicu committed Jun 28, 2014
    Configuration menu
    Copy the full SHA
    8b81768 View commit details
    Browse the repository at this point in the history

  3. Maintain coding style consistency; remove additional empty lines

    @badescunicu
    badescunicu committed Jun 28, 2014
    Configuration menu
    Copy the full SHA
    94177af View commit details
    Browse the repository at this point in the history

  4. Remove the hard coded check boxes from dlgprefeqdlg.ui

    @badescunicu
    badescunicu committed Jun 28, 2014
    Configuration menu
    Copy the full SHA
    fb64948 View commit details
    Browse the repository at this point in the history

  5. Connect [Master],num_decks' value changed signal to the slot which ad… 

    …ds a QComboBox for each deck
    @badescunicu
    badescunicu committed Jun 28, 2014
    Configuration menu
    Copy the full SHA
    776323c View commit details
    Browse the repository at this point in the history

  6. Remove the hard coded initialization of the EQ Effect Rack

    @badescunicu
    badescunicu committed Jun 28, 2014
    Configuration menu
    Copy the full SHA
    f72071f View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2014

  1. Remove temporary hack for accessing DlgPrefEQ as it is no longer needed

    @badescunicu
    badescunicu committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    872341d View commit details
    Browse the repository at this point in the history

  2. Add labels for each QComboBox

    @badescunicu
    badescunicu committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    be04f6a View commit details
    Browse the repository at this point in the history

  3. Add a QLabel to dlgprefeqdlg.ui

    @badescunicu
    badescunicu committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    9e4ef33 View commit details
    Browse the repository at this point in the history

  4. Remove effect instantiation in addEffectChainSlotForEQ; now dlgprefeq… 

    ….cpp is dictating when to load an effect
    @badescunicu
    badescunicu committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    aa97b18 View commit details
    Browse the repository at this point in the history

  5. Store user's configuration of the Effect Rack

    @badescunicu
    badescunicu committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    657658b View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2014

  1. m_pConfig is deleted inside mixxx.cpp; this was causing an incorrect … 

    …shutdown of Mixxx
    @badescunicu
    badescunicu committed Jun 30, 2014
    Configuration menu
    Copy the full SHA
    b20cb78 View commit details
    Browse the repository at this point in the history

  2. Introduce a check box for configuring the Effect Rack (basic/advanced… 

    … view)
    @badescunicu
    badescunicu committed Jun 30, 2014
    Configuration menu
    Copy the full SHA
    3fa8cc7 View commit details
    Browse the repository at this point in the history

  3. Add a flag in EffectManifest to keep track if an effect is an Equaliz… 

    …er or not
    @badescunicu
    badescunicu committed Jun 30, 2014
    Configuration menu
    Copy the full SHA
    b18c59e View commit details
    Browse the repository at this point in the history

  4. Add another method in EffectsManager class which returns the availabl… 

    …e Equalizers
    @badescunicu
    badescunicu committed Jun 30, 2014
    Configuration menu
    Copy the full SHA
    babb40c View commit details
    Browse the repository at this point in the history

  5. Use getAvailableEQEffects inside DlgPrefEQ

    @badescunicu
    badescunicu committed Jun 30, 2014
    Configuration menu
    Copy the full SHA
    5aef2b0 View commit details
    Browse the repository at this point in the history

  6. Mark EQDefault as an EQ Effect

    @badescunicu
    badescunicu committed Jun 30, 2014
    Configuration menu
    Copy the full SHA
    ce76dd8 View commit details
    Browse the repository at this point in the history

  7. Add methods for retrieving the available effects names

    @badescunicu
    badescunicu committed Jun 30, 2014
    Configuration menu
    Copy the full SHA
    a27f92a View commit details
    Browse the repository at this point in the history

  8. Use itemData() field for storing the effect ID. currentText() is stor… 

    …es the name of the current effect
    @badescunicu
    badescunicu committed Jun 30, 2014
    Configuration menu
    Copy the full SHA
    80c960f View commit details
    Browse the repository at this point in the history

  9. Rename a couple of methods and variables

    @badescunicu
    badescunicu committed Jun 30, 2014
    Configuration menu
    Copy the full SHA
    c7bfc2f View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2014

  1. Modify getAvailableEffectNames and getAvailableEQEffectNames to retur… 

    …n a set of pairs containing the effect id and its name
    @badescunicu
    badescunicu committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    bda0da7 View commit details
    Browse the repository at this point in the history

  2. Use the newly modified methods to fix the link between combo box's te… 

    …xt and its data
    @badescunicu
    badescunicu committed Jul 1, 2014
    Configuration menu
    Copy the full SHA
    1e95377 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2014

  1. Instantiate controls needed by equalizers inside EffectsManager

    @badescunicu
    badescunicu committed Jul 2, 2014
    Configuration menu
    Copy the full SHA
    fa36e3c View commit details
    Browse the repository at this point in the history

  2. Remove EngineFilterBlock from EngineDeck

    @badescunicu
    badescunicu committed Jul 2, 2014
    Configuration menu
    Copy the full SHA
    b64f3cb View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2014

  1. Merge master and fix conflicts

    @badescunicu
    badescunicu committed Aug 11, 2014
    Configuration menu
    Copy the full SHA
    2dbece9 View commit details
    Browse the repository at this point in the history

  2. Mark Butterworth8EQEffect as an EQ Effect

    @badescunicu
    badescunicu committed Aug 11, 2014
    Configuration menu
    Copy the full SHA
    afcc172 View commit details
    Browse the repository at this point in the history

  3. Create aliases needed for the EQ Rack

    @badescunicu
    badescunicu committed Aug 11, 2014
    Configuration menu
    Copy the full SHA
    b5c9f2f View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2014

  1. Use a loop to create aliases needed for the EQ rack

    @badescunicu
    badescunicu committed Aug 13, 2014
    Configuration menu
    Copy the full SHA
    b89544d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:badescunicu/mixxx into eq_rack

    @badescunicu
    badescunicu committed Aug 13, 2014
    Configuration menu
    Copy the full SHA
    6cc37d4 View commit details
    Browse the repository at this point in the history

  3. Remove the radio buttons from EQ Preferences and enable internal EQ

    @badescunicu
    badescunicu committed Aug 13, 2014
    Configuration menu
    Copy the full SHA
    6c59fa0 View commit details
    Browse the repository at this point in the history

  4. Remove EngineFilterBlock

    @badescunicu
    badescunicu committed Aug 13, 2014
    Configuration menu
    Copy the full SHA
    d016e61 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2014

  1. Add a Bypass check box to EQ Preferences and implement the logic behi… 

    …nd it.
    @badescunicu
    badescunicu committed Aug 14, 2014
    Configuration menu
    Copy the full SHA
    3875241 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2014

  1. Create the aliases inside EffectsManager::addEqualizer instead of har… 

    …d coding them in MixxxMainWindow::createCOAliases
    @badescunicu
    badescunicu committed Aug 16, 2014
    Configuration menu
    Copy the full SHA
    b02cc8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:badescunicu/mixxx into eq_rack

    @badescunicu
    badescunicu committed Aug 16, 2014
    Configuration menu
    Copy the full SHA
    b04311f View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2014

  1. Fix conflicts

    @badescunicu
    badescunicu committed Sep 4, 2014
    Configuration menu
    Copy the full SHA
    94b4013 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2014

  1. Fix for logarithmic control hint

    @badescunicu
    badescunicu committed Sep 5, 2014
    Configuration menu
    Copy the full SHA
    40a5eb6 View commit details
    Browse the repository at this point in the history

  2. Set kEffectDebugOutput to false

    @badescunicu
    badescunicu committed Sep 5, 2014
    Configuration menu
    Copy the full SHA
    795e47b View commit details
    Browse the repository at this point in the history

  3. Remove commented out line from enginedeck.cpp

    @badescunicu
    badescunicu committed Sep 5, 2014
    Configuration menu
    Copy the full SHA
    feb19f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2014

  1. Fix some coding style issues and mark a couple of strings for translate

    @badescunicu
    badescunicu committed Sep 10, 2014
    Configuration menu
    Copy the full SHA
    818c873 View commit details
    Browse the repository at this point in the history

  2. Remove effectprocessor.cpp because it was not used throughout the cod… 

    …e base
    @badescunicu
    badescunicu committed Sep 10, 2014
    Configuration menu
    Copy the full SHA
    e82a1ab View commit details
    Browse the repository at this point in the history

  3. Add getEQEffectRack method to EffectsManager

    @badescunicu
    badescunicu committed Sep 10, 2014
    2 Configuration menu
    Copy the full SHA
    358e074 View commit details
    Browse the repository at this point in the history

  4. Use getEQEffectRack method inside DlgPrefEQ

    @badescunicu
    badescunicu committed Sep 10, 2014
    Configuration menu
    Copy the full SHA
    0343ab6 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2014

  1. Add getEQEffectRackNumber method to EffectsManager

    @badescunicu
    badescunicu committed Sep 12, 2014
    Configuration menu
    Copy the full SHA
    fb70322 View commit details
    Browse the repository at this point in the history

  2. Rename checkBox_bypass to CheckBoxBypass

    @badescunicu
    badescunicu committed Sep 12, 2014
    Configuration menu
    Copy the full SHA
    490dcd6 View commit details
    Browse the repository at this point in the history

  3. Use another approach at bypassing the EQ Rack 

    Instead of loading an empty effect on each deck, set the control responsible for enabling an effect to 0
    @badescunicu
    badescunicu committed Sep 12, 2014
    Configuration menu
    Copy the full SHA
    e47fe35 View commit details
    Browse the repository at this point in the history

  4. Store the effects' ids as configs instead of their names

    @badescunicu
    badescunicu committed Sep 12, 2014
    Configuration menu
    Copy the full SHA
    ef107cc View commit details
    Browse the repository at this point in the history