Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchbar clear #3262

Merged
merged 11 commits into from
Feb 17, 2021
Merged

Searchbar clear #3262

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2067fa4
Change searchbar clear behaviour
poelzi Nov 2, 2020
a142b4c
Merge branch 'main' of https://github.com/mixxxdj/mixxx into searchba…
poelzi Jan 18, 2021
895d3c0
Revert search clear button focus change
poelzi Jan 18, 2021
3d5a94b
WSearchLineEdit: let Up key clear text before save timer runs out
ronso0 Feb 14, 2021
d7b36ba
WSearchLineEdit: let Clear only clear the text, not the history lp:19…
ronso0 Feb 14, 2021
6a4f9d9
WSearchLineEdit: use slotClearSearch() for Up key events
ronso0 Feb 14, 2021
9ab695e
Merge pull request #4 from ronso0/search-clear-fix
poelzi Feb 15, 2021
2f729a3
WSearchLineEdit: comment Up key / clear behaviour
ronso0 Feb 15, 2021
973e836
WSearchLineEdit: don't intercept Up/Down keys if the popup is open
ronso0 Feb 17, 2021
619f9fc
WSearchLineEdit: use lineEdit()->clear() instead of setText("")
ronso0 Feb 17, 2021
8da91b9
Merge pull request #5 from ronso0/search-clear-fix
poelzi Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/widget/wsearchlineedit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ WSearchLineEdit::WSearchLineEdit(QWidget* pParent)

m_clearButton->setCursor(Qt::ArrowCursor);
m_clearButton->setObjectName(QStringLiteral("SearchClearButton"));
m_clearButton->setFocusPolicy(Qt::ClickFocus);
Copy link
Member

@ronso0 ronso0 Nov 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree:
how do you quickly clear the search from a controller now?
Scrolling all the way to the top of the search history is no option for me.

I know this was requested on Zulip because someone uses a custom mappin for the Trax encoder press and wants to reduce the Tabs necessary to get to the tracks table, but the default most common mapping is [Library],GoToItem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current system is also problematic for blind users as the tab order changes depending on the state of the search bar.

I'm ambivalent about the focus behaviour. What's the general stand towards this ?

// Query style for arrow width and frame border
updateStyleMetrics();

Expand Down Expand Up @@ -280,7 +281,13 @@ QString WSearchLineEdit::getSearchText() const {
bool WSearchLineEdit::eventFilter(QObject* obj, QEvent* event) {
if (event->type() == QEvent::KeyPress) {
QKeyEvent* keyEvent = static_cast<QKeyEvent*>(event);
if (keyEvent->key() == Qt::Key_Down) {
if (keyEvent->key() == Qt::Key_Up) {
if (findCurrentTextIndex() == 0) {
setCurrentIndex(-1);
setCurrentText("");
return true;
}
} else if (keyEvent->key() == Qt::Key_Down) {
// after clearing the text field the down key is expected to
// show the last entry
if (currentText().isEmpty()) {
Expand Down