controllers/controllerengine: Disable DEBUG_ASSERT on invalid key #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
force-pushed
the
controllerengine-softtakeover-assert
branch
from
fd5c640
to
29847fc
Compare
uklotzde
reviewed
Aug 30, 2020
Holzhaus
force-pushed
the
controllerengine-softtakeover-assert
branch
from
29847fc
to
423b99c
Compare
uklotzde
reviewed
Aug 30, 2020
| @@ -23,6 +23,7 @@ enum class ControlFlag { | |||
| NoAssertIfMissing = 1 << 1, | |||
| /// Don't log a warning when trying to access a non-existing CO. | |||
| NoWarnIfMissing = (1 << 2) | NoAssertIfMissing, | |||
| AllowMissingOrInvalid = AllowInvalidKey | NoAssertIfMissing, | |||
|
No need to wait on delayed macOS CI builds. LGTM |
|
@Holzhaus Merging 2.3 into master requires to resolve some merge conflicts. Would you please take care of that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.