-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Down beat range #3036
base: main
Are you sure you want to change the base?
[POC] Down beat range #3036
Conversation
Most of the implementation is copied and slighly cleaned for consistency from beatutils. The rest comes from mixxxdj#2847
Change needed to do multi feature detection without redoing the STFTs
The change in qm-dsp broke queen mary beats
… into rhythm-detector
… into rhythm-detector
…ams values as vamp plugin
* Adjust the Boom vs Tshak compensation curve with more test tracks * Use a smmoothing filter for the floating threshold after detecting a beat * Look also to the falling edge of a beat when finding SD peaks
… into rhythm-detector
…o detect downbeats with it.
This is for example the complex SD of a track with two visible section/phrase changes. The idea is that the down-beat must be at such a change. We "just" need to find these places as anchor for all other down beats. You see, that the section change is not at the peak beats. That's why searching for peaks fails. |
This is a typical result from the AutoCorrelation Debug [AnalyzerThread 0 #2]: measurelength 211 (21, 43, 64, 85, 149, 170, 340, 679) Currently MIxxx will pick 170 as measure length which is 1,93 s. The part which is hard to decide if this is a 4/4 or a 7/8 Track, because the 149 is also detected. |
You could try to apply a FIR filter on the SD output. The filter should consider the beats of two bars. Than you get a smooth curve. If you calculate the first derivative of this curve, I would expect clear peaks at the first and the last musical change. |
This PR is marked as stale because it has been open 90 days with no activity. |
This is just a POC branch that tries to improve various issues, discoverer during testing the new Rhythm detector.
This implements the following:
(It is too sensitive and works only Sometimes)
This branch uses the possible Section changes as beats. In the current state it is not very helpful thoug.
This Branch also prints a LOT to the console. It can be copied into a csv file and imported to LibreOffice which can show Diagrams usefull fro debugging.