engine/controls: Remove superfluous notifySeek implementations

[xeruf]

Most of the time this isn't needed, because the process method is called afterwards and sets the new position anyways.

Hand-checked them all, not sure about the scratching yet though.

Tests haven't finished yet.

[xeruf]

Okay, so the Sync seek test is failing. Unfortunately I don't know enough here - I thought since the updated position is already processed in postProcess, it doesn't need to be set separately through notifySeek.
But maybe this is merely an insignificant difference depending on implementation details?

[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from EngineSyncTest
[ RUN      ] EngineSyncTest.UserTweakPreservedInSeek
/home/janek/daten/projects/mixxx/mixxx/src/test/enginesynctest.cpp:1915: Failure
Expected equality of these values:
  0.2269025
  ControlObject::get(ConfigKey(m_sGroup1, "playposition"))
    Which is: 0.22701859
/home/janek/daten/projects/mixxx/mixxx/src/test/enginesynctest.cpp:1918: Failure
Expected equality of these values:
  0.12403101
  ControlObject::get(ConfigKey(m_sGroup1, "beat_distance"))
    Which is: 0.12527132

Btw, why I am doing this: I probably need to add a parameter to notifySeek for hotcue jumps to record macros, so I wanted to reduce the affected calls.

[Holzhaus]

This is never called anymore. Could explain the failing test.

[github-actions]

This PR is marked as stale because it has been open 90 days with no activity.

[xeruf]

can someone rerun the checks? The logs are expired and I'm not sure anymore whether the failing test was fixed.

[Holzhaus]

Please pull in main, restarting the workflow isn't possible because it's too old.

[Holzhaus]

Hmm, thank you. All tests still pass, so these notifySeek implementations may indeed by superfluous. @daschuer do you want to take another look?

[ywwg]

If the tests pass then I'm ok with merging. We have a lot of tests for various seek conditions so it should be sufficiently covered. If we find a missing case, then oh well :)