-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover art support #278
Cover art support #278
Commits on Oct 21, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 92247eb - Browse repository at this point
Copy the full SHA 92247ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34d48aa - Browse repository at this point
Copy the full SHA 34d48aaView commit details -
Prevent deep-copy of QImage while checksumming it and move calculateHash
to CoverArtUtils.
Configuration menu - View commit details
-
Copy full SHA for af707e4 - Browse repository at this point
Copy the full SHA af707e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f987621 - Browse repository at this point
Copy the full SHA f987621View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d2fa92 - Browse repository at this point
Copy the full SHA 5d2fa92View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb265df - Browse repository at this point
Copy the full SHA eb265dfView commit details
Commits on Oct 23, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 0f3f844 - Browse repository at this point
Copy the full SHA 0f3f844View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cf9b8a - Browse repository at this point
Copy the full SHA 8cf9b8aView commit details
Commits on Oct 26, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 1af2430 - Browse repository at this point
Copy the full SHA 1af2430View commit details -
Remove default cover handling from CoverArtCache.
Add <DefaultCover> configuration option to WCoverArt to let skin authors pick a default cover.
Configuration menu - View commit details
-
Copy full SHA for f3eff5c - Browse repository at this point
Copy the full SHA f3eff5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32d9da9 - Browse repository at this point
Copy the full SHA 32d9da9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08edc49 - Browse repository at this point
Copy the full SHA 08edc49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ecde90 - Browse repository at this point
Copy the full SHA 1ecde90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bbb903 - Browse repository at this point
Copy the full SHA 7bbb903View commit details -
* Move cache key formatting to its own method. * Explicitly handle the no-size cache key.
Configuration menu - View commit details
-
Copy full SHA for 7c199cb - Browse repository at this point
Copy the full SHA 7c199cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 107f9f9 - Browse repository at this point
Copy the full SHA 107f9f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 807f621 - Browse repository at this point
Copy the full SHA 807f621View commit details -
Configuration menu - View commit details
-
Copy full SHA for 679f786 - Browse repository at this point
Copy the full SHA 679f786View commit details
Commits on Oct 27, 2014
-
Pull file extension regex generator into a utility file.
Add helper to create a supported cover art extensions regex.
Configuration menu - View commit details
-
Copy full SHA for b1b0f5e - Browse repository at this point
Copy the full SHA b1b0f5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2057607 - Browse repository at this point
Copy the full SHA 2057607View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdf1a03 - Browse repository at this point
Copy the full SHA cdf1a03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8183dc0 - Browse repository at this point
Copy the full SHA 8183dc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 672111c - Browse repository at this point
Copy the full SHA 672111cView commit details -
* Move cover search out of the CoverArtCache workers. * Get rid of dedicated table for cover art (and add more columns to library table) * Delete CoverArtDAO and test. * Add cover scanning to LibraryScanner. * Load and store cover art in TrackInfoObject via TrackDAO. * Hook cover columns up to cached TrackInfoObjects in BaseTrackCache. * Get rid of "ID3TAG" string to identify metadata. Use CoverInfo::Type instead. * Add source tracking for cover provenance (user-selected vs. auto-selected) so we know whether it's safe to change a cover without losing user data. * Add helper for reloading cover art from file. * Use relative paths to cover art so FILE art is not broken by folder moves.
Configuration menu - View commit details
-
Copy full SHA for 42c8155 - Browse repository at this point
Copy the full SHA 42c8155View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5f2fc5 - Browse repository at this point
Copy the full SHA a5f2fc5View commit details -
Rework WCoverArt <-> WTrackTableView signal flow.
* Communicate selected track instead of cover art. * Support connecting a WCoverArt to the track currently loaded to a deck.
Configuration menu - View commit details
-
Copy full SHA for 5ef00f4 - Browse repository at this point
Copy the full SHA 5ef00f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0477ae7 - Browse repository at this point
Copy the full SHA 0477ae7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7000a9b - Browse repository at this point
Copy the full SHA 7000a9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8572aa4 - Browse repository at this point
Copy the full SHA 8572aa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59ee4e5 - Browse repository at this point
Copy the full SHA 59ee4e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae905d5 - Browse repository at this point
Copy the full SHA ae905d5View commit details -
Rename issueRepaint to signalWhenDone and remove update of WTrackTabl…
…eView on requestCover completion for delegate requests.
Configuration menu - View commit details
-
Copy full SHA for cd4b3c8 - Browse repository at this point
Copy the full SHA cd4b3c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c0c1bb - Browse repository at this point
Copy the full SHA 9c0c1bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 587ee29 - Browse repository at this point
Copy the full SHA 587ee29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 946cb34 - Browse repository at this point
Copy the full SHA 946cb34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 356d48c - Browse repository at this point
Copy the full SHA 356d48cView commit details
Commits on Oct 28, 2014
-
Configuration menu - View commit details
-
Copy full SHA for afdeb96 - Browse repository at this point
Copy the full SHA afdeb96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0855f56 - Browse repository at this point
Copy the full SHA 0855f56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60c5853 - Browse repository at this point
Copy the full SHA 60c5853View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9aa413 - Browse repository at this point
Copy the full SHA e9aa413View commit details -
Improve connection between WCoverArtMenu, WCoverArtLabel, WCoverArt, …
…and DlgTrackInfo. * Remove copying of changed cover art into the folder (temporarily?). * Mark all user-generated change events as USER_SELECTED. * Remove reliance on CoverInfo::trackId in a couple places.
Configuration menu - View commit details
-
Copy full SHA for 9bbbea5 - Browse repository at this point
Copy the full SHA 9bbbea5View commit details -
Disconnect TIO changed signals while applying track info edits.
How did editing metadata work at all before?
Configuration menu - View commit details
-
Copy full SHA for 31991b8 - Browse repository at this point
Copy the full SHA 31991b8View commit details -
Don't crop cached pixmaps anymore.
Scale (preserving aspect ratio) and cache them by (hash, width) only. Cropping doesn't really save any paint time since QPainter::drawPixmap is cheap when you don't have to scale the pixmap.
Configuration menu - View commit details
-
Copy full SHA for fb7570e - Browse repository at this point
Copy the full SHA fb7570eView commit details -
Add coverArtUpdated signal to TrackInfoObject.
Listen to the signal in WCoverArt.
Configuration menu - View commit details
-
Copy full SHA for 8e11ac5 - Browse repository at this point
Copy the full SHA 8e11ac5View commit details -
Configuration menu - View commit details
-
Copy full SHA for da949ae - Browse repository at this point
Copy the full SHA da949aeView commit details -
Allow segregation of multiple users of CoverArtCache.
* Provide a QObject* requestor pointer when calling requestCover. In practice this can be any number you want it to but it is particularly useful for the requestor class to pass a pointer to itself so it can compare the signal it gets to itself. * Provide the original CoverInfo request.
Configuration menu - View commit details
-
Copy full SHA for 8b77640 - Browse repository at this point
Copy the full SHA 8b77640View commit details -
Configuration menu - View commit details
-
Copy full SHA for 359dade - Browse repository at this point
Copy the full SHA 359dadeView commit details -
Make a CoverArtUtils::selectCoverArtForTrack variant that doesn't
require a TrackPointer.
Configuration menu - View commit details
-
Copy full SHA for 139a05a - Browse repository at this point
Copy the full SHA 139a05aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0cd784 - Browse repository at this point
Copy the full SHA c0cd784View commit details -
Configuration menu - View commit details
-
Copy full SHA for abf7eca - Browse repository at this point
Copy the full SHA abf7ecaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4132de - Browse repository at this point
Copy the full SHA a4132deView commit details -
Configuration menu - View commit details
-
Copy full SHA for b90c5c6 - Browse repository at this point
Copy the full SHA b90c5c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea87686 - Browse repository at this point
Copy the full SHA ea87686View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33509d1 - Browse repository at this point
Copy the full SHA 33509d1View commit details -
Merge remote-tracking branch 'cardinot/coverArtSupport' into
coverart_test * Update WTrackTableView changes to match new WCoverArtMenu behavior. * Remove DirectoryDAO integration for now. Conflicts: src/library/coverartcache.cpp src/library/coverartcache.h src/widget/wcoverartmenu.cpp src/widget/wcoverartmenu.h
Configuration menu - View commit details
-
Copy full SHA for 29777ea - Browse repository at this point
Copy the full SHA 29777eaView commit details
Commits on Oct 29, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 49fee52 - Browse repository at this point
Copy the full SHA 49fee52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43cde9e - Browse repository at this point
Copy the full SHA 43cde9eView commit details -
Remove trackId from CoverInfo.
* Add a request reference integer to CoverArtCache::requestCover. Use (pRequestor, requestReference) for de-duping requests instead of trackId.
Configuration menu - View commit details
-
Copy full SHA for d081ff7 - Browse repository at this point
Copy the full SHA d081ff7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d4105c - Browse repository at this point
Copy the full SHA 1d4105cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc82b07 - Browse repository at this point
Copy the full SHA dc82b07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94e511e - Browse repository at this point
Copy the full SHA 94e511eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06b1952 - Browse repository at this point
Copy the full SHA 06b1952View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c48c06 - Browse repository at this point
Copy the full SHA 0c48c06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 320a803 - Browse repository at this point
Copy the full SHA 320a803View commit details -
Use cover hash as request reference in CoverArtDelegate.
Now only loads a cover once for rows that share the same hash.
Configuration menu - View commit details
-
Copy full SHA for dbe9811 - Browse repository at this point
Copy the full SHA dbe9811View commit details
Commits on Oct 30, 2014
-
Sorts by the hash. It works well except for the case where cover art is similar but not exactly the same. I think it's good enough to include, even if some users may be confused why visually similar cover art doesn't sort together.
Configuration menu - View commit details
-
Copy full SHA for f9e9148 - Browse repository at this point
Copy the full SHA f9e9148View commit details -
Delay trackSelected signal until the user interaction timeout.
Improves scrolling performance when scrolling via keyboard.
Configuration menu - View commit details
-
Copy full SHA for 343f7c0 - Browse repository at this point
Copy the full SHA 343f7c0View commit details -
Only repaint cells that were cache misses when we hit the user
interaction timeout.
Configuration menu - View commit details
-
Copy full SHA for 07fd51f - Browse repository at this point
Copy the full SHA 07fd51fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0425bc4 - Browse repository at this point
Copy the full SHA 0425bc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d0f864 - Browse repository at this point
Copy the full SHA 3d0f864View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa683d8 - Browse repository at this point
Copy the full SHA fa683d8View commit details -
Revert DlgTrackInfo parentage change.
In DlgCoverArtFullSize, max across all top level windows to get the appropriate size for the cover art. Maybe this fixes the original issue?
Configuration menu - View commit details
-
Copy full SHA for 3468571 - Browse repository at this point
Copy the full SHA 3468571View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dea56a - Browse repository at this point
Copy the full SHA 8dea56aView commit details
Commits on Oct 31, 2014
-
Configuration menu - View commit details
-
Copy full SHA for e394457 - Browse repository at this point
Copy the full SHA e394457View commit details -
Configuration menu - View commit details
-
Copy full SHA for dddeb3b - Browse repository at this point
Copy the full SHA dddeb3bView commit details -
Support multiple-selection for cover art menu in WTrackTableView.
* Adds CoverArtCache::guessCover(s) methods for calling CoverArtUtils::guessCoverArt in a background thread. * Removes processing of reset menu option from WCoverArtMenu and instead sends a signal that the owner of the menu should handle.
Configuration menu - View commit details
-
Copy full SHA for 0980b6b - Browse repository at this point
Copy the full SHA 0980b6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf7c539 - Browse repository at this point
Copy the full SHA cf7c539View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7329e9 - Browse repository at this point
Copy the full SHA a7329e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ad6b5d - Browse repository at this point
Copy the full SHA 4ad6b5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3e2c5c - Browse repository at this point
Copy the full SHA f3e2c5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24874c5 - Browse repository at this point
Copy the full SHA 24874c5View commit details
Commits on Nov 5, 2014
-
Only save images in TIO if it is not NULL
Max Linke committedNov 5, 2014 Configuration menu - View commit details
-
Copy full SHA for b95c452 - Browse repository at this point
Copy the full SHA b95c452View commit details -
Reduce code duplication in finding possible Covers
Max Linke committedNov 5, 2014 Configuration menu - View commit details
-
Copy full SHA for 09b16a3 - Browse repository at this point
Copy the full SHA 09b16a3View commit details -
Move CoverArtUtil tests to own class
Max Linke committedNov 5, 2014 Configuration menu - View commit details
-
Copy full SHA for 46fbd24 - Browse repository at this point
Copy the full SHA 46fbd24View commit details -
Codying style clean up coverartcache
Max Linke committedNov 5, 2014 Configuration menu - View commit details
-
Copy full SHA for 82085f3 - Browse repository at this point
Copy the full SHA 82085f3View commit details -
Use COSlave instead of COThread
ControlObjectThread is deprecated all new CO's should be of type ControlObjectSlave
Max Linke committedNov 5, 2014 Configuration menu - View commit details
-
Copy full SHA for 76113d0 - Browse repository at this point
Copy the full SHA 76113d0View commit details