Fix manual ducking #2759
Fix manual ducking #2759
Conversation
now the ducking gain is only applied when talkover is enabled
daschuer
force-pushed
the
manual_ducking_fix
branch
from
cca9725 to
27a585e
Compare
| // clear state from the last round of compressor gain calculation. | ||
| void clearKeys(); | ||
| /// Forces the above threshold flag to the given value without calculations | ||
| void setAboveThreshold(bool value); |
There was a problem hiding this comment.
This could be inline like the other setXyz() functions above.
|
Nice, thank you for the fix. I was about to propose that fix. Fixes https://bugs.launchpad.net/mixxx/+bug/1394968 and I can close #2006. Thx! |
src/engine/enginemaster.cpp
Outdated
| m_pTalkoverDucking->processKey(m_pTalkover, m_iBufferSize); | ||
| break; | ||
| case EngineTalkoverDucking::MANUAL: | ||
| qDebug() << "m_activeTalkoverChannels.size()" << m_activeTalkoverChannels.size(); |
There was a problem hiding this comment.
In debug log in real-time code??
Previously, engine/enginetalkoverducking returned opposite values
for 'strength' in Auto and Manual mode. This commit removes the
inversion from Auto mode, thus the Strength knob always affects the
music volume in the same way with both modes, much like a Muisc Volume
knob: * fully left: music muted completely
* fully right: music volume unchanged
|
Just that I get our Merge policy straight, finally:
So if I get that right the first two commits should be squashed, then we Merge Commit, right? |
|
I think we should either |
|
The general rule applies here, no rebase during a review. That's easy and saved all parties from extra work. I must admit that since the found issue effects the top most commit, I should have sqashed that. |
Now the ducking gain is only applied when talkover is enabled.
Before the manual mode has always applied the Ducking gain. This does not make much sense, because the user can also lower the deck gain to have the same effect.
This Fixes a a regression since the introduction of the postfader effects in 2.1