Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDJ-SB2] Fixes auto tempo going to infinity bug. #2559

Merged
merged 2 commits into from
Mar 19, 2020
Merged

[DDJ-SB2] Fixes auto tempo going to infinity bug. #2559

merged 2 commits into from
Mar 19, 2020

Conversation

mab122
Copy link
Contributor

@mab122 mab122 commented Mar 17, 2020

https://bugs.launchpad.net/mixxx/+bug/1856403/

When auto tempo adjustment is turned on it cannot be turned off.
That is because the code only disables it when rate is equal to 0.
But it only executes above check when variable speed(== rate) is DIFFERENT than 0.

@mab122 mab122 changed the title Fixes auto tempo going to infinity bug. [DDJ-SB2] Fixes auto tempo going to infinity bug. Mar 17, 2020
@Holzhaus
Copy link
Member

Hey @mab122, thanks for your contribution. While you're at it, can you fix the Code Style issues that were discovered by our CI? https://travis-ci.org/github/mixxxdj/mixxx/jobs/663696708#L1221
You can fix most of them automatically by using pre-commit.

Just install pre-commit and then run:

$ pre-commit run --files res/controllers/Pioneer-DDJ-SB2-scripts.js

Also, I guess that this bug is also present in the current Mixxx 2.2.3 release, right? That means that this bug should be fixed in the next bugfix release (2.2.4), not the next major release (2.3.0). Unfortunately, you filed this PR against the master branch (which is used for 2.3.0 development), not the 2.2 branch. Can you please rebase on 2.2 after fixing the linter issues? See https://mixxx.org/wiki/doku.php/using_git#targeting_another_base_branch for details how to do that.

@Holzhaus Holzhaus added this to the 2.2.4 milestone Mar 18, 2020
@mab122 mab122 changed the base branch from master to 2.2 March 18, 2020 14:56
@mab122 mab122 changed the base branch from 2.2 to master March 18, 2020 14:57
@mab122 mab122 force-pushed the bug1856403-ddjsb2-autotempo-goes-infinity branch from d2e2edf to 6feb23a Compare March 18, 2020 16:24
@mab122 mab122 changed the base branch from master to 2.2 March 18, 2020 16:25
@mab122 mab122 force-pushed the bug1856403-ddjsb2-autotempo-goes-infinity branch from 6feb23a to 6a4cade Compare March 18, 2020 16:32
@mab122
Fixes auto tempo going to infinity bug
1c9631b 
When auto tempo adjustment is turned on it cannot be turned off.
lp:1856403
Also this change marks unused variables (no more warnings by eslinter)
@mab122 mab122 force-pushed the bug1856403-ddjsb2-autotempo-goes-infinity branch from 6a4cade to 1c9631b Compare March 18, 2020 17:16
Holzhaus
Holzhaus approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much.

@Holzhaus Holzhaus merged commit 60b54e4 into mixxxdj:2.2 Mar 19, 2020
Holzhaus added a commit to Holzhaus/mixxx that referenced this pull request Mar 19, 2020
@Holzhaus
CHANGELOG: Add entry for Pioneer DDJ-SB2 auto tempo fix (mixxxdj#2559)
2225254
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

Assignees
No one assigned
Labels
controller mappings
Projects
None yet
Milestone
2.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mab122 @Holzhaus