Store remaining Rekordbox memory cues as hotcues #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
reviewed
Mar 12, 2020
uklotzde
reviewed
Mar 13, 2020
|
Unrelated: Should we log the occurrence of loops that get ignored because Mixxx doesn't support multiple loops yet? |
|
It would be straight forward to qDebug log information about loops ignored, I would also suggest changing the the way the first loop is currently determined to similarly storing and sorting a QList of found loops, ready for when Mixxx does support multiple loops. Should this be a separate PR or just a commit to this PR? |
|
Let's merge this PR first. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rekordbox has multiple memory cues and multiple hot cues. As Mixxx only has one main cue, only the first Rekordbox memory cue found was used, all others were discarded. This PR adds the remaining memory cues found (after the first) as Mixxx hotcues. They are also added after any found Rekordbox hotcues, to preserve consistency.
This is as discussed here: https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Rekordbox.20removable.20device.20library.20feature.20PR/near/186346855