Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow changing track colors from controller #2541

Merged
merged 8 commits into from
Apr 19, 2020
Merged

Allow changing track colors from controller #2541

merged 8 commits into from
Apr 19, 2020

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Mar 8, 2020

Similar to what #2384 did for hotcue colors, this allows changing the current track color from a controller script. Since most controllers lack dedicated controls for this, I mapped this to "press and hold shift + press and hold browse know + turn browse knob" on my Roland DJ-505.

If someone has a better idea how to make this accessible on controllers, let me know ;-)

@Holzhaus Holzhaus force-pushed the track-colors-from-controller branch from 5c72e95 to 22d5f23 Compare March 20, 2020 10:43
@Holzhaus Holzhaus changed the title [WIP] Allow changing track colors from controller Allow changing track colors from controller Mar 20, 2020
@Holzhaus Holzhaus added this to the 2.3.0 milestone Mar 20, 2020
@Be-ing Be-ing mentioned this pull request Mar 25, 2020
Merged
2 tasks
@Holzhaus
Copy link
Member Author

Holzhaus commented Apr 9, 2020

Merge?

@Be-ing
Copy link
Contributor

Be-ing commented Apr 9, 2020

Could you also add a [ChannelX], color Control that allows for explicitly getting/setting an exact color like hotcues?

@Holzhaus Holzhaus requested a review from Be-ing April 13, 2020 12:15
@Holzhaus Holzhaus self-assigned this Apr 13, 2020
@Holzhaus
Copy link
Member Author

Could you also add a [ChannelX], color Control that allows for explicitly getting/setting an exact color like hotcues?

Any idea where I should add it? EngineBuffer (where the other track-related COs live) doesn't seem right. Also, it doesn't store a TrackPointer so don't know how to react to value changes.

@Be-ing
Copy link
Contributor

Be-ing commented Apr 14, 2020

BaseTrackPlayer

@Holzhaus
Copy link
Member Author

Could you also add a [ChannelX], color Control that allows for explicitly getting/setting an exact color like hotcues?

See #2665.

@Holzhaus
Copy link
Member Author

Merge?

@Holzhaus
Copy link
Member Author

All the track-related COs have now been removed from WTrackTableView. I have no idea where to put the track color COs now. WTrackMenu doesn't seem right, since it has nothing to do with the menu. Any ideas?

@Be-ing
Copy link
Contributor

Be-ing commented Apr 17, 2020

These new ControlObjects are directly related to the track table, so I think WTrackTableView is good enough. Maybe TrackModel would be better?

@Holzhaus Holzhaus marked this pull request as draft April 18, 2020 10:04
@Holzhaus
Copy link
Member Author

Merge conflicts resolved.

@Holzhaus Holzhaus marked this pull request as ready for review April 18, 2020 15:34
Be-ing
Be-ing reviewed Apr 18, 2020
View reviewed changes
src/library/libraryview.h Outdated Show resolved Hide resolved
@Be-ing Be-ing merged commit f1e13f9 into mixxxdj:master Apr 19, 2020
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Open
@mxmilkiib mxmilkiib mentioned this pull request Mar 2, 2024
Closed
This was referenced Apr 7, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing left review comments

Assignees

@Holzhaus Holzhaus

Labels
controller mappings library
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Holzhaus @Be-ing