Make Mixxx compile even though QT_NO_OPENGL or QT_OPENGL_ES_2 is defined #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Feb 16, 2020
uklotzde
reviewed
Feb 16, 2020
| @@ -6,6 +6,7 @@ | |||
| #include "waveform/waveformwidgetfactory.h" | |||
| #include "util/math.h" | |||
|
|
|||
| #if !defined(QT_NO_OPENGL) && !defined(QT_OPENGL_ES_2) | |||
There was a problem hiding this comment.
Same here, why not exclude the whole file content?
uklotzde
suggested changes
Feb 16, 2020
|
Done. |
|
Compile fails on Raspberry Pi with the following: https://pastebin.com/nVUucQkC |
|
This is strange it looks like glslwaveformrenderersignal.h is skipped. It is IMHO skipped under the same conditions like the whole cpp file. I guess hoverver, even more strange is because there is nothing in between. Ideas? |
|
Did you use scons or cmake? Please try this: catch the command line for building glslwaveformrenderersignal.cpp |
|
Please create and post the glvsynctestrenderer.i file. It is the copy file with all preprocessor detectives extracted. This can be created by running scons again with additional verbose=1 |
|
Please test again. |
|
This now compiles without errors on Raspberry Pi, thank you. Whilst running however there is continual output as reported here: https://bugs.launchpad.net/mixxx/+bug/1863368 even after increasing the RPi video memory to 128MB and 256MB. I initially temporarily stopped this by commenting out Line 402 in bd8aa08 |
uklotzde
approved these changes
Feb 25, 2020
|
LGTM. All open issues should be addressed by follow-up PRs. |
|
I also just updated https://mixxx.org/wiki/doku.php/compiling_on_linux to reflect that very little is different from the Debian / Ubuntu compile process on Raspbian now, and removed the references to opengles=1. |
Merged
|
Compiling fails with this error, when trying to compile with cmake in latest raspbian on a raspberry pi 4b. |
|
It will be fixed with: |
|
Btw: wich device do you use and what is your waveforms setting? |
|
A raspberry pi 4b with 4GB ram and a freshly flashed SD with Raspbian Buster fully updated. I tried compiling branch 2.3 again last night, but I have not been able to successfully build Mixxx with cmake in this setup, so I haven't set any waveform settings yet. Previously I have build Mixxx 2.3 successfully using Scons in a similar device, but notably this was with Ubuntu Mate as OS instead of Raspbian. |
|
Unfortunately the build process continues to fail on armhf. Here is the output generated: |
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the building on Raspberry Pi
https://bugs.launchpad.net/mixxx/+bug/1863440